Re: [PATCH] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP images

2022-08-28 Thread Pali Rohár
On Sunday 28 August 2022 05:47:51 Marek Behún wrote: > Can you rename the option to > OF_FDT_READONLY_BEFORE_RELOC > ? I do not care what is the name of this option. All other options for this configuration have OF and DTB in its name, not FDT, and that is why I chose the current name. > The

Re: [PATCH] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP images

2022-08-27 Thread Marek Behún
Can you rename the option to OF_FDT_READONLY_BEFORE_RELOC ? The INITIAL in the name may confuse people. The functions are called *_fdt (reloc_fdt, fix_fdt), so maybe put FDT instead of DTB in the config option name. Marek

[PATCH] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP images

2022-08-27 Thread Pali Rohár
When U-Boot is running from flash memory (execute in place) then gd->fdt_blob before relocation points to read-only flash memory. So U-Boot calls board_fix_fdt() with read-only gd->fdt_blob pointer which cause immediate CPU crash when callback is trying to modify gd->fdt_blob. Fix this issue by