Re: [PATCH] boot: don't enable booti/bootz by default if FIT_SIGNATURE is set

2021-11-04 Thread Simon Glass
Hi, On Thu, 4 Nov 2021 at 05:23, Heinrich Schuchardt wrote: > > > > On 11/4/21 04:11, Rover Mo wrote: > > Dear Heinrich, > > > > > > Thank for your comments. > > > > > > >How about CONFIG_EFI_SECURE_BOOT? Should this also disable the default? > > > > I think yes. > > I will update the relation t

Re: [PATCH] boot: don't enable booti/bootz by default if FIT_SIGNATURE is set

2021-11-04 Thread Heinrich Schuchardt
On 11/4/21 04:11, Rover Mo wrote: Dear Heinrich, Thank for your comments. >How about CONFIG_EFI_SECURE_BOOT? Should this also disable the default? I think yes. I will update the relation to "default y if !FIT_SIGNATURE && !EFI_SECURE_BOOT", and add "!EFI_SECURE_BOOT" into LEGACY_IMAGE_FO

Re:Re: [PATCH] boot: don't enable booti/bootz by default if FIT_SIGNATURE is set

2021-11-03 Thread Rover Mo
Dear Heinrich, Thank for your comments. >How about CONFIG_EFI_SECURE_BOOT? Should this also disable the default? I think yes. I will update the relation to "default y if !FIT_SIGNATURE && !EFI_SECURE_BOOT", and add "!EFI_SECURE_BOOT" into LEGACY_IMAGE_FORMAT. >> + It is enabled b

[PATCH] boot: don't enable booti/bootz by default if FIT_SIGNATURE is set

2021-11-03 Thread Rover Mo
To prevent boot unsigned images, same as CONFIG_LEGACY_IMAGE_FORMAT, don't enable CONFIG_CMD_BOOTI and CONFIG_CMD_BOOTI by default if CONFIG_FIT_SIGNATURE is enabled. Signed-off-by: Yuezhang.Mo --- cmd/Kconfig | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/cmd/Kc

Re: [PATCH] boot: don't enable booti/bootz by default if FIT_SIGNATURE is set

2021-11-03 Thread Heinrich Schuchardt
On 11/3/21 08:44, Rover Mo wrote: To prevent boot unsigned images, same as CONFIG_LEGACY_IMAGE_FORMAT, nits: %s/boot/booting/ don't enable CONFIG_CMD_BOOTI and CONFIG_CMD_BOOTI by default if CONFIG_FIT_SIGNATURE is enabled. Disabling the booti and the bootz command does not stop you from bo