Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-09 Thread Marek Vasut
On 12/8/23 01:16, Shantur Rathore wrote: Hi Marek, On Tue, Dec 5, 2023 at 5:40 AM Marek Vasut wrote: On 12/4/23 13:10, Shantur Rathore wrote: On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: On 12/4/23 11:59, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-07 Thread Shantur Rathore
Hi Marek, On Tue, Dec 5, 2023 at 5:40 AM Marek Vasut wrote: > > On 12/4/23 13:10, Shantur Rathore wrote: > > On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: > >> > >> On 12/4/23 11:59, Shantur Rathore wrote: > >>> Hi Marek, > >>> > >>> On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: > >>>

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Marek Vasut
On 12/4/23 13:10, Shantur Rathore wrote: On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: On 12/4/23 11:59, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: On 12/3/23 22:42, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Shantur Rathore
On Mon, Dec 4, 2023 at 11:05 AM Marek Vasut wrote: > > On 12/4/23 11:59, Shantur Rathore wrote: > > Hi Marek, > > > > On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: > >> > >> On 12/3/23 22:42, Shantur Rathore wrote: > >>> Hi Marek, > >>> > >>> On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Marek Vasut
On 12/4/23 11:59, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: On 12/3/23 22:42, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: On 11/24/23 01:37, Shantur Rathore wrote: Hi Marek, Hi, sorry for the late reply.

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-04 Thread Shantur Rathore
Hi Marek, On Sun, Dec 3, 2023 at 10:37 PM Marek Vasut wrote: > > On 12/3/23 22:42, Shantur Rathore wrote: > > Hi Marek, > > > > On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: > >> > >> On 11/24/23 01:37, Shantur Rathore wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >> sorry for the late reply.

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Marek Vasut
On 12/3/23 22:42, Shantur Rathore wrote: Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: On 11/24/23 01:37, Shantur Rathore wrote: Hi Marek, Hi, sorry for the late reply. In my case RockPro64, the power to usb ports onboard is controlled by a regulator. This regulator is ena

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Shantur Rathore
Hi Marek, On Sun, Dec 3, 2023 at 8:42 PM Marek Vasut wrote: > > On 11/24/23 01:37, Shantur Rathore wrote: > > Hi Marek, > > Hi, > > sorry for the late reply. > > > In my case RockPro64, the power to usb ports onboard is controlled by > > a regulator. > > This regulator is enabled as p

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-12-03 Thread Marek Vasut
On 11/24/23 01:37, Shantur Rathore wrote: Hi Marek, Hi, sorry for the late reply. In my case RockPro64, the power to usb ports onboard is controlled by a regulator. This regulator is enabled as part of init as here https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/rk3399-rockpro64.d

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-23 Thread Shantur Rathore
Hi Marek, On Thu, Nov 23, 2023 at 9:07 PM Marek Vasut wrote: > > On 11/23/23 12:24, Shantur Rathore wrote: > > Hi Marek, > > > > On Thu, Nov 23, 2023 at 12:06 AM Marek Vasut wrote: > >> > >> On 11/20/23 00:03, Shantur Rathore wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>> On Sun, Nov 19, 2023 a

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-23 Thread Marek Vasut
On 11/23/23 12:24, Shantur Rathore wrote: Hi Marek, On Thu, Nov 23, 2023 at 12:06 AM Marek Vasut wrote: On 11/20/23 00:03, Shantur Rathore wrote: Hi Marek, Hi, On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: On 11/10/23 15:13, Shantur Rathore wrote: Currently when a hub is turned

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-23 Thread Shantur Rathore
Hi Marek, On Thu, Nov 23, 2023 at 12:06 AM Marek Vasut wrote: > > On 11/20/23 00:03, Shantur Rathore wrote: > > Hi Marek, > > Hi, > > > On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > >> > >> On 11/10/23 15:13, Shantur Rathore wrote: > >>> Currently when a hub is turned on, all the ports ar

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-22 Thread Marek Vasut
On 11/20/23 00:03, Shantur Rathore wrote: Hi Marek, Hi, On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: On 11/10/23 15:13, Shantur Rathore wrote: Currently when a hub is turned on, all the ports are powered on. This works well for hubs which have individual power control. For the hubs

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-19 Thread Shantur Rathore
On Sun, Nov 19, 2023 at 11:03 PM Shantur Rathore wrote: > > Hi Marek, > > On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > > > > On 11/10/23 15:13, Shantur Rathore wrote: > > > Currently when a hub is turned on, all the ports are powered on. > > > This works well for hubs which have individua

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-19 Thread Shantur Rathore
Hi Marek, On Sun, Nov 19, 2023 at 8:53 PM Marek Vasut wrote: > > On 11/10/23 15:13, Shantur Rathore wrote: > > Currently when a hub is turned on, all the ports are powered on. > > This works well for hubs which have individual power control. > > > > For the hubs without individual power control t

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-19 Thread Marek Vasut
On 11/10/23 15:13, Shantur Rathore wrote: Currently when a hub is turned on, all the ports are powered on. This works well for hubs which have individual power control. For the hubs without individual power control this has no effect. OK Mostly in these scenarios the hub port is powered befo

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-15 Thread Marek Vasut
On 11/15/23 09:26, Shantur Rathore wrote: Hi Marek, Hi, What is the point of this growing CC list ? Apologies, this is my first time with email based patch management. I was reading articles on best practices and first one mentioned to cc people with recent commits, second one mentioned to

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-15 Thread Shantur Rathore
Hi Marek, > What is the point of this growing CC list ? Apologies, this is my first time with email based patch management. I was reading articles on best practices and first one mentioned to cc people with recent commits, second one mentioned to use get_maintainer script to cc people and hence m

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-14 Thread Marek Vasut
On 11/14/23 21:49, Shantur Rathore wrote: +Patrice +Patrick from get_maintainer script What is the point of this growing CC list ?

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-14 Thread Shantur Rathore
+Patrice +Patrick from get_maintainer script On Mon, Nov 13, 2023 at 1:28 PM Shantur Rathore wrote: > > +Simon +Trini > > On Fri, Nov 10, 2023 at 2:13 PM Shantur Rathore wrote: > > > > Currently when a hub is turned on, all the ports are powered on. > > This works well for hubs which have indivi

Re: [PATCH] common: usb-hub: Reset hub port before scanning

2023-11-13 Thread Shantur Rathore
+Simon +Trini On Fri, Nov 10, 2023 at 2:13 PM Shantur Rathore wrote: > > Currently when a hub is turned on, all the ports are powered on. > This works well for hubs which have individual power control. > > For the hubs without individual power control this has no effect. > Mostly in these scenari

[PATCH] common: usb-hub: Reset hub port before scanning

2023-11-10 Thread Shantur Rathore
Currently when a hub is turned on, all the ports are powered on. This works well for hubs which have individual power control. For the hubs without individual power control this has no effect. Mostly in these scenarios the hub port is powered before the USB controller is enabled, this can lead to

[PATCH] common: usb-hub: Reset hub port before scanning

2023-11-10 Thread Shantur Rathore
Currently when a hub is turned on, all the ports are powered on. This works well for hubs which have individual power control. For the hubs without individual power control this has no effect. Mostly in these scenarios the hub port is powered before the USB controller is enabled, this can lead to