Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-17 Thread Pali Rohár
On Monday 16 January 2023 16:33:09 Tony Dinh wrote: > Hi all, > > On Sat, Jan 14, 2023 at 1:45 PM Tony Dinh wrote: > > > > Hi Pali & Tom, > > > > On Sat, Jan 14, 2023 at 12:06 PM Pali Rohár wrote: > > > > > > On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > > > > On Sat, Jan 14, 2023 at 07

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-16 Thread Tony Dinh
On Mon, Jan 16, 2023 at 4:33 PM Tony Dinh wrote: > > Hi all, > > On Sat, Jan 14, 2023 at 1:45 PM Tony Dinh wrote: > > > > Hi Pali & Tom, > > > > On Sat, Jan 14, 2023 at 12:06 PM Pali Rohár wrote: > > > > > > On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > > > > On Sat, Jan 14, 2023 at 07:

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-16 Thread Tony Dinh
Hi all, On Sat, Jan 14, 2023 at 1:45 PM Tony Dinh wrote: > > Hi Pali & Tom, > > On Sat, Jan 14, 2023 at 12:06 PM Pali Rohár wrote: > > > > On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > > > On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > > > > On Friday 13 January 2023 21:0

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Tony Dinh
Hi Pali & Tom, On Sat, Jan 14, 2023 at 12:06 PM Pali Rohár wrote: > > On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > > > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pal

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Pali Rohár
On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > >

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_buil

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Pali Rohár
On Friday 13 January 2023 21:00:21 Tom Rini wrote: > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_build_message.o > > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_common.o > > >

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-13 Thread Tom Rini
On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_build_message.o > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_common.o > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_spd.o > > obj-$(CONFIG_SP

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-13 Thread Pali Rohár
On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_build_message.o > obj-$(CONFIG_SPL_BUILD) += mv_ddr_common.o > obj-$(CONFIG_SPL_BUILD) += mv_ddr_spd.o > obj-$(CONFIG_SPL_BUILD) += mv_ddr_topology.o > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_mp

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-13 Thread Pali Rohár
Hello! Thanks for this DDR4 patch. I have a few comments below, mostly about adding dead/removed code. On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > This syncs drivers/ddr/marvell/a38x/ with the master branch of repository > https://github.com/MarvellEmbeddedProcessors/mv-ddr-marv