Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Siddharth Vadapalli
On 24/02/20 03:24PM, Siddharth Vadapalli wrote: > On 24/02/20 12:51PM, Dan Carpenter wrote: > > On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote: > > > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > > > index eea9ec9659..8a6625f034 100644 > > > --- a/drivers/d

Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Siddharth Vadapalli
On 24/02/20 12:51PM, Dan Carpenter wrote: > On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote: > > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > > index eea9ec9659..8a6625f034 100644 > > --- a/drivers/dma/ti/k3-udma.c > > +++ b/drivers/dma/ti/k3-udma.c > > @@

Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Dan Carpenter
On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote: > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > index eea9ec9659..8a6625f034 100644 > --- a/drivers/dma/ti/k3-udma.c > +++ b/drivers/dma/ti/k3-udma.c > @@ -1770,9 +1770,11 @@ static int udma_probe(struct udevi

[PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-16 Thread Siddharth Vadapalli
In udma_probe() the return value of setup_resources() is stored in the u32 "ch_count" member of "struct udma_dev", due to which any negative return value which indicates an error is masked. Fix this by storing the return value of setup_resources() in the already declared integer variable "ret", fo