Re: [PATCH] drivers: mmc: support secure erase.

2021-01-04 Thread Jaehoon Chung
Hi Dennis, On 1/1/21 8:42 PM, dennis laplacian1 wrote: > Hi Jaehoon. > The only degradation is that the check will be for every block in the > deleted range and not for the range. > I can move the check to mmc_erase_t, but then if the device is not > supporting secure erase the error message will

Re: [PATCH] drivers: mmc: support secure erase.

2021-01-01 Thread dennis laplacian1
Hi Jaehoon. The only degradation is that the check will be for every block in the deleted range and not for the range. I can move the check to mmc_erase_t, but then if the device is not supporting secure erase the error message will be printed for every block. I can check the support also in mmc_be

Re: [PATCH] drivers: mmc: support secure erase.

2020-12-27 Thread Jaehoon Chung
Hi Dennis, On 12/26/20 5:44 PM, dennis laplacian1 wrote: > Hi Jaehoon Chung, > for your comment: > "ditto. if (IS_ENABLED()) instead of #if. > And i don't know why doesn't check this in mmc_erase_t(). > Then it doesn't need to pass arg as argument." > > I check the support of secure erase in the

Re: [PATCH] drivers: mmc: support secure erase.

2020-12-26 Thread dennis laplacian1
Hi Jaehoon Chung, for your comment: "ditto. if (IS_ENABLED()) instead of #if. And i don't know why doesn't check this in mmc_erase_t(). Then it doesn't need to pass arg as argument." I check the support of secure erase in the mmc_berase and not in mmc_erase_t because mmc_erase_t is called multiple

Re: [PATCH] drivers: mmc: support secure erase.

2020-12-21 Thread Jaehoon Chung
Hi, CC'd Peng (mmc maintainer). On 12/18/20 10:21 PM, dennis wrote: > According to the JEDEC Standard, eMMC v4.4 cards can supoort secure erase. > the first bit in ext_csd[EXT_CSD_SEC_FEATURE_SUPPORT] - EXT_CSD_SEC_ER_EN > is used to check if secure erase supoort by the device. %s/supoort/suppor

[PATCH] drivers: mmc: support secure erase.

2020-12-18 Thread dennis
According to the JEDEC Standard, eMMC v4.4 cards can supoort secure erase. the first bit in ext_csd[EXT_CSD_SEC_FEATURE_SUPPORT] - EXT_CSD_SEC_ER_EN is used to check if secure erase supoort by the device. Signed-off-by: dennis --- drivers/mmc/Kconfig | 8 drivers/mmc/mmc.c |