Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-04-18 Thread Tom Rini
On Mon, Jan 11, 2021 at 11:27:20AM +0100, Martin Fuzzey wrote: > Since commit 0f036bf4b87e ("env: Warn on force access if > ENV_ACCESS_IGNORE_FORCE set") > a warning message is displayed when setenv -f is used WITHOUT > CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting > i

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-02-03 Thread Marek Vasut
On 2/1/21 8:31 PM, Tom Rini wrote: On Fri, Jan 29, 2021 at 12:03:52AM +0100, Marek Vasut wrote: On 1/28/21 8:26 PM, Tom Rini wrote: On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: On 1/11/21 11:27 AM, Martin Fuzzey wrote: Since commit 0f036bf4b87e ("env: Warn on force access if E

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-02-01 Thread Tom Rini
On Fri, Jan 29, 2021 at 12:03:52AM +0100, Marek Vasut wrote: > On 1/28/21 8:26 PM, Tom Rini wrote: > > On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: > > > On 1/11/21 11:27 AM, Martin Fuzzey wrote: > > > > Since commit 0f036bf4b87e ("env: Warn on force access if > > > > ENV_ACCESS_IG

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-29 Thread Marek Vasut
On 1/29/21 8:42 AM, Fuzzey, Martin wrote: On Fri, 29 Jan 2021 at 00:05, Marek Vasut wrote: On 1/28/21 8:37 PM, Fuzzey, Martin wrote: Hi Marek, Hi, On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: Based on env/Kconfig description of this option: config ENV_ACCESS_IGNORE_FORCE

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Fuzzey, Martin
On Fri, 29 Jan 2021 at 00:05, Marek Vasut wrote: > > On 1/28/21 8:37 PM, Fuzzey, Martin wrote: > > Hi Marek, > > Hi, > > > On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: > >> > >> Based on env/Kconfig description of this option: > >> > >> config ENV_ACCESS_IGNORE_FORCE > >> bool "Blo

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 8:37 PM, Fuzzey, Martin wrote: Hi Marek, Hi, On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: Based on env/Kconfig description of this option: config ENV_ACCESS_IGNORE_FORCE bool "Block forced environment operations" default n help If

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 8:26 PM, Tom Rini wrote: On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: On 1/11/21 11:27 AM, Martin Fuzzey wrote: Since commit 0f036bf4b87e ("env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set") a warning message is displayed when setenv -f is used WITHOUT CONFIG

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Fuzzey, Martin
Hi Marek, On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: > > Based on env/Kconfig description of this option: > > config ENV_ACCESS_IGNORE_FORCE > bool "Block forced environment operations" > default n > help >If defined, don't allow the -f switch to env

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: > On 1/11/21 11:27 AM, Martin Fuzzey wrote: > > Since commit 0f036bf4b87e ("env: Warn on force access if > > ENV_ACCESS_IGNORE_FORCE set") > > a warning message is displayed when setenv -f is used WITHOUT > > CONFIG_ENV_ACCESS_IGNORE_FOR

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/11/21 11:27 AM, Martin Fuzzey wrote: Since commit 0f036bf4b87e ("env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set") a warning message is displayed when setenv -f is used WITHOUT CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting in lots of log pollution. env_

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 10:11 AM, Heinrich Schuchardt wrote: [...] diff --git a/env/flags.c b/env/flags.c index df4aed2..e3e833c 100644 --- a/env/flags.c +++ b/env/flags.c @@ -563,12 +563,13 @@ int env_flags_validate(const struct env_entry *item, const char *newval, Please, add a Sphinx style function desc

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Tom Rini
On Fri, Jan 15, 2021 at 01:43:44PM -0500, Tom Rini wrote: > On Mon, Jan 11, 2021 at 11:27:20AM +0100, Martin Fuzzey wrote: > > > Since commit 0f036bf4b87e ("env: Warn on force access if > > ENV_ACCESS_IGNORE_FORCE set") > > a warning message is displayed when setenv -f is used WITHOUT > > CONFIG_

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Heinrich Schuchardt
On 11.01.21 11:27, Martin Fuzzey wrote: > Since commit 0f036bf4b87e ("env: Warn on force access if > ENV_ACCESS_IGNORE_FORCE set") > a warning message is displayed when setenv -f is used WITHOUT > CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting > in lots of log pollution.

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-15 Thread Tom Rini
On Mon, Jan 11, 2021 at 11:27:20AM +0100, Martin Fuzzey wrote: > Since commit 0f036bf4b87e ("env: Warn on force access if > ENV_ACCESS_IGNORE_FORCE set") > a warning message is displayed when setenv -f is used WITHOUT > CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting > i

[PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-11 Thread Martin Fuzzey
Since commit 0f036bf4b87e ("env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set") a warning message is displayed when setenv -f is used WITHOUT CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting in lots of log pollution. env_flags_validate() returns 0 if the access is