Re: [PATCH] env: sf: add support for env erase

2020-10-14 Thread Harry Waschkeit
 On 10/9/20 7:00 PM, Sean Anderson wrote: On 10/9/20 12:43 PM, Harry Waschkeit wrote: Hi Sean, thanks for your try and sorry for the inconvenience my beginner's mistakes have caused :-( It is definitely no good idea to use copy&paste with patch data, I should have guessed that beforehand ...

Re: [PATCH] env: sf: add support for env erase

2020-10-09 Thread Sean Anderson
On 10/9/20 12:43 PM, Harry Waschkeit wrote: > Hi Sean, > > thanks for your try and sorry for the inconvenience my beginner's mistakes > have > caused :-( > > It is definitely no good idea to use copy&paste with patch data, I should have > guessed that beforehand ... You *can* do it, you just ha

Re: [PATCH] env: sf: add support for env erase

2020-10-09 Thread Harry Waschkeit
Hi Sean, thanks for your try and sorry for the inconvenience my beginner's mistakes have caused :-( It is definitely no good idea to use copy&paste with patch data, I should have guessed that beforehand ... Anyway, concerning the complaints from checkpatch.pl: I indeed ran checkpatch.pl on my p

Re: [PATCH] env: sf: add support for env erase

2020-10-09 Thread Sean Anderson
On 10/8/20 1:27 PM, Harry Waschkeit wrote: > Command "env erase" didn't work even though CONFIG_CMD_ERASEENV was > defined, because serial flash environment routines didn't implement > erase method. > > Signed-off-by: Waschkeit, Harry > --- Hi Harry, I wanted to test out your patch, but I could

[PATCH] env: sf: add support for env erase

2020-10-08 Thread Harry Waschkeit
Command "env erase" didn't work even though CONFIG_CMD_ERASEENV was defined, because serial flash environment routines didn't implement erase method. Signed-off-by: Waschkeit, Harry --- env/sf.c | 130 ++- 1 file changed, 128 insertions(+), 2