Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-08 Thread Miquel Raynal
Hi Jincheng, jc.w...@gmail.com wrote on Wed, 8 Jun 2022 11:37:13 +0800: > To be honest, I don't have experience > > Reference to the article " > https://events19.linuxfoundation.org/wp-content/uploads/2018/07/may_be_maintainer-2.pdf"; > , I tried to do some work. > > 1. checkpatch (√) > 2.

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Jincheng Wang
To be honest, I don't have experience Reference to the article " https://events19.linuxfoundation.org/wp-content/uploads/2018/07/may_be_maintainer-2.pdf"; , I tried to do some work. 1. checkpatch (√) 2. no new compile warnings (√) 3. if bug fix, verify the bug is fixed (√) I tried some

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 06:00:38PM +0800, Jincheng Wang wrote: > It works well, thanks for your work. Can you please provide a Tested-by? Thanks! > > > Miquel Raynal 于2022年6月3日周五 23:26写道: > > > > Following Jincheng's report, an out-of-band write leading to arbitrary > > code execution is pos

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Jincheng Wang
It works well, thanks for your work. Miquel Raynal 于2022年6月3日周五 23:26写道: > > Following Jincheng's report, an out-of-band write leading to arbitrary > code execution is possible because on one side the squashfs logic > accepts directory names up to 65535 bytes (u16), while U-Boot fs logic > accep

[PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-03 Thread Miquel Raynal
Following Jincheng's report, an out-of-band write leading to arbitrary code execution is possible because on one side the squashfs logic accepts directory names up to 65535 bytes (u16), while U-Boot fs logic accepts directory names up to 255 bytes long. Prevent such an exploit from happening by ca