Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-18 Thread Fabio Estevam
On Tue, Jan 18, 2022 at 1:13 PM Harm Berntsen wrote: > I did not check the manual assignment of bit 30 in the dts, I now see > that it is used more often than I thought. > > I'm using an imx8mn on U-Boot 2021.10. It was as simple as setting the > pinctrl as you described and in the same way as An

Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-18 Thread Harm Berntsen
Hi, On Mon, 2022-01-17 at 13:57 -0300, Fabio Estevam wrote: > Hi Harm, > > Adding Angus, who submitted a similar patch: > https://patchwork.ozlabs.org/project/uboot/patch/20211128145143.1433262-1-an...@akkea.ca/ > > On Mon, Jan 17, 2022 at 12:55 PM Harm Berntsen > wrote: > > > > Could this iss

Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-17 Thread Fabio Estevam
Hi Harm, Adding Angus, who submitted a similar patch: https://patchwork.ozlabs.org/project/uboot/patch/20211128145143.1433262-1-an...@akkea.ca/ On Mon, Jan 17, 2022 at 12:55 PM Harm Berntsen wrote: > > Could this issue be fixed by setting the SION bit mode? > > SION works! I did not know about

Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-17 Thread Harm Berntsen
Hi Fabio Estevam and Ye Li, On Sat, 2022-01-15 at 10:43 -0300, Fabio Estevam wrote: > Hi Harm and Ye Li, > > On Fri, Aug 13, 2021 at 11:35 AM Harm Berntsen > wrote: > > > > Currently the driver gets value from PSR register, but this > > register is > > only for input mode. For output mode, it a

Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-15 Thread Fabio Estevam
Hi Harm and Ye Li, On Fri, Aug 13, 2021 at 11:35 AM Harm Berntsen wrote: > > Currently the driver gets value from PSR register, but this register is > only for input mode. For output mode, it always returns 0, not the value > we set for output. > > This patch changes to use DR register, which ret

[PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2021-08-13 Thread Harm Berntsen
Currently the driver gets value from PSR register, but this register is only for input mode. For output mode, it always returns 0, not the value we set for output. This patch changes to use DR register, which returns the DR value for output mode, and PSR value for input mode. This patch is based