Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-06 Thread Mattijs Korpershoek
Hi, On Thu, 01 Feb 2024 13:18:51 -0500, Sean Anderson wrote: > The return value of write_sparse_chunk_raw is unsigned, so the existing > check has no effect. Use IS_ERR_VALUE to detect error instead, which is > what write_sparse_chunk_raw does itself. > > Thanks, Applied to

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-02 Thread Mattijs Korpershoek
Hi Sean, Thank you for the patch. On Thu, Feb 01, 2024 at 13:18, Sean Anderson wrote: > The return value of write_sparse_chunk_raw is unsigned, so the existing > check has no effect. Use IS_ERR_VALUE to detect error instead, which is > what write_sparse_chunk_raw does itself. > > Fixes:

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-01 Thread Michael Nazzareno Trimarchi
On Thu, Feb 1, 2024 at 7:19 PM Sean Anderson wrote: > > The return value of write_sparse_chunk_raw is unsigned, so the existing > check has no effect. Use IS_ERR_VALUE to detect error instead, which is > what write_sparse_chunk_raw does itself. > > Fixes: 62649165cb0 ("lib: sparse: Make

[PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-01 Thread Sean Anderson
The return value of write_sparse_chunk_raw is unsigned, so the existing check has no effect. Use IS_ERR_VALUE to detect error instead, which is what write_sparse_chunk_raw does itself. Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") Reported-by: Dan Carpenter Link: