Re: [PATCH] mmc: rockchip_sdhci: Correct error checking

2022-03-28 Thread Jaehoon Chung
On 3/22/22 21:58, li.hao...@qq.com wrote: > From: Haolin Li > > A pointer can not be negative. Use macro IS_ERR_OR_NULL() for checking. > > Signed-off-by: Haolin Li Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/rockchip_sdhci.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH] mmc: rockchip_sdhci: Correct error checking

2022-03-28 Thread Kever Yang
Hi Haolin,     Thanks for your patch. On 2022/3/22 20:58, li.hao...@qq.com wrote: From: Haolin Li A pointer can not be negative. Use macro IS_ERR_OR_NULL() for checking. Signed-off-by: Haolin Li Reviewed-by: Kever Yang Thanks, - Kever --- drivers/mmc/rockchip_sdhci.c | 2 +- 1 file

Re: [PATCH] mmc: rockchip_sdhci: Correct error checking

2022-03-23 Thread Simon Glass
On Tue, 22 Mar 2022 at 06:58, wrote: > > From: Haolin Li > > A pointer can not be negative. Use macro IS_ERR_OR_NULL() for checking. > > Signed-off-by: Haolin Li > --- > drivers/mmc/rockchip_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

[PATCH] mmc: rockchip_sdhci: Correct error checking

2022-03-22 Thread li . haolin
From: Haolin Li A pointer can not be negative. Use macro IS_ERR_OR_NULL() for checking. Signed-off-by: Haolin Li --- drivers/mmc/rockchip_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index f3f9d83ba3..a4