Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Oleksandr Suvorov
Hi Marek, On Sun, Jan 24, 2021 at 4:52 PM Marek Vasut wrote: > > On 1/24/21 3:35 PM, Oleksandr Suvorov wrote: > > On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: > >> > >> Hi Marek, > >> > >> On 23.01.21 20:57, Marek Vasut wrote: > >>> On 1/23/21 8:54 PM, sba...@denx.de wrote: > > The

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Marek Vasut
On 1/24/21 3:35 PM, Oleksandr Suvorov wrote: On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: Hi Marek, On 23.01.21 20:57, Marek Vasut wrote: On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-24 Thread Oleksandr Suvorov
On Sun, Jan 24, 2021 at 12:04 AM Stefano Babic wrote: > > Hi Marek, > > On 23.01.21 20:57, Marek Vasut wrote: > > On 1/23/21 8:54 PM, sba...@denx.de wrote: > >>> The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which > >>> supports OF control, correctly set the rgmii-id PHY mode in

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread Stefano Babic
Hi Marek, On 23.01.21 20:57, Marek Vasut wrote: On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC interna

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread Marek Vasut
On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode. [...] Applied t

[PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread sbabic
> The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which > supports OF control, correctly set the rgmii-id PHY mode in the DT and > then determine whether or not to enable the FEC RXC/TXC internal delay > based on the PHY mode. > Signed-off-by: Marek Vasut > Cc: Oleksandr Suvorov

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread Stefano Babic
Hi Marek, this rather breaks old platforms - I check with mx25pdk, but also mx35 is broken. Could you take a look ? Thanks ! +drivers/net/fec_mxc.c:510:9: error: 'struct fec_priv' has no member named 'interface' + 510 | if (fec->interface == PHY_INTERFACE_MODE_RGMII_ID || + | ^~ +d

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-20 Thread Oleksandr Suvorov
Hi Marek, On Tue, Jan 19, 2021 at 1:57 AM Marek Vasut wrote: > > The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which > supports OF control, correctly set the rgmii-id PHY mode in the DT and > then determine whether or not to enable the FEC RXC/TXC internal delay > based on the

[PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-18 Thread Marek Vasut
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode. Signed-off-by: Marek Vasut Cc: Oleksandr Suvorov Cc: Stefano