Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-05-02 Thread Stefan Roese
Applied to u-boot-marvell/master Thanks, Stefan On 26.04.22 00:01, Tony Dinh wrote: Hi Stefan, On Mon, Apr 25, 2022 at 4:18 AM Stefan Roese wrote: Hi Tony, On 4/25/22 11:33, Tony Dinh wrote: Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: Hi Tony, On 4/23/22 04:15, To

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Tony Dinh
Hi Stefan, On Mon, Apr 25, 2022 at 4:18 AM Stefan Roese wrote: > > Hi Tony, > > On 4/25/22 11:33, Tony Dinh wrote: > > Hi Stefan, > > > > On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: > >> > >> Hi Tony, > >> > >> On 4/23/22 04:15, Tony Dinh wrote: > >>> Hi Stefan, > >>> > >>> Please see m

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Stefan Roese
Hi Tony, On 4/25/22 11:33, Tony Dinh wrote: Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: Hi Tony, On 4/23/22 04:15, Tony Dinh wrote: Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: Hi

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Tony Dinh
Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: > > Hi Tony, > > On 4/23/22 04:15, Tony Dinh wrote: > > Hi Stefan, > > > > Please see my various comments below. And my thoughts at the end. > > > > On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: > >> > >> Hi Tony, > >> > >> O

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-24 Thread Stefan Roese
Hi Tony, On 4/23/22 04:15, Tony Dinh wrote: Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: Hi Tony, On 4/21/22 23:21, Tony Dinh wrote: What really puzzles me is, why the page address is set to a non-zero

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-22 Thread Tony Dinh
Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: > > Hi Tony, > > On 4/21/22 23:21, Tony Dinh wrote: > > > > >> What really puzzles me is, why the page address is set to a non-zero > >> value at all at this early b

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-21 Thread Stefan Roese
Hi Tony, On 4/21/22 23:21, Tony Dinh wrote: What really puzzles me is, why the page address is set to a non-zero value at all at this early boot stage? Could you perhaps add some debugging code, to check, if and where the page address gets set? I find it hard to belief, that this starts with

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-21 Thread Tony Dinh
Hi Stefan, On Thu, Apr 21, 2022 at 7:26 AM Stefan Roese wrote: > > Hi Tony, > > On 4/21/22 03:45, Tony Dinh wrote: > > Hi Stefan, > > > > On Tue, Apr 19, 2022 at 1:47 PM Tony Dinh wrote: > >> > >> Hi Stefan, > >> > >> On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: > >>> > >>> Hi Tony, > >>

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-21 Thread Stefan Roese
Hi Tony, On 4/21/22 03:45, Tony Dinh wrote: Hi Stefan, On Tue, Apr 19, 2022 at 1:47 PM Tony Dinh wrote: Hi Stefan, On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: Hi Tony, On 4/12/22 22:18, Tony Dinh wrote: For most Kirkwood boards, the PHY page is already set to page 0 (in registe

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-20 Thread Tony Dinh
Hi Stefan, On Tue, Apr 19, 2022 at 1:47 PM Tony Dinh wrote: > > Hi Stefan, > > On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: > > > > Hi Tony, > > > > On 4/12/22 22:18, Tony Dinh wrote: > > > For most Kirkwood boards, the PHY page is already set to page 0 > > > (in register 22) before phy_c

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-19 Thread Tony Dinh
Hi Stefan, On Tue, Apr 19, 2022 at 3:29 AM Stefan Roese wrote: > > Hi Tony, > > On 4/12/22 22:18, Tony Dinh wrote: > > For most Kirkwood boards, the PHY page is already set to page 0 > > (in register 22) before phy_connect is invoked. But some board like > > the Zyxel NSA310S (which uses the netw

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-19 Thread Stefan Roese
Hi Tony, On 4/12/22 22:18, Tony Dinh wrote: For most Kirkwood boards, the PHY page is already set to page 0 (in register 22) before phy_connect is invoked. But some board like the Zyxel NSA310S (which uses the network chip MV88E1318S), the PHY page is not set to page 0. There seems to be some ba

[PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-12 Thread Tony Dinh
For most Kirkwood boards, the PHY page is already set to page 0 (in register 22) before phy_connect is invoked. But some board like the Zyxel NSA310S (which uses the network chip MV88E1318S), the PHY page is not set to page 0. There seems to be some bad data remained in register 22 when the uclass