Re: [PATCH] net: phy: ncsi: Correct the endian of the checksum

On Mon, Feb 05, 2024 at 04:02:28PM +0800, Jacky Chou wrote: > There is no need to perform the endian twice here. > > Signed-off-by: Jacky Chou > Reviewed-by: Dan Carpenter Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: RE: [PATCH] net: phy: ncsi: Correct the endian of the checksum

Anyway, looks good! I already gave my reviewed by. Thanks for your work on this. regards, dan carpenter

RE: RE: [PATCH] net: phy: ncsi: Correct the endian of the checksum

> On Sun, Mar 03, 2024 at 02:14:43AM +, Jacky Chou wrote: > > Hi Dan Carpenter, > > > > I have verified it on the little-endian platform, such as ASPEED AST2600. > > Awesome. Thanks for this. > > > I think put_unaligned_be32() and htonl() functions have no effect on > big-endian platforms. >

Re: 回覆: [PATCH] net: phy: ncsi: Correct the endian of the checksum

On Sun, Mar 03, 2024 at 02:14:43AM +, Jacky Chou wrote: > Hi Dan Carpenter, > > I have verified it on the little-endian platform, such as ASPEED AST2600. Awesome. Thanks for this. > I think put_unaligned_be32() and htonl() functions have no effect on > big-endian platforms. > And keep put_

回覆: [PATCH] net: phy: ncsi: Correct the endian of the checksum

寄件者: Dan Carpenter 寄件日期: 2024年2月5日 下午 11:04 收件者: Jacky Chou 副本: joe.hershber...@ni.com ; rfried@gmail.com ; tr...@konsulko.com ; michal.si...@amd.com ; marek.vasut+rene...@mailbox.org ; u-boot@lists.denx.de ; BMC-SW 主旨: Re: [PATCH] net: phy: ncsi: Correct

Re: [PATCH] net: phy: ncsi: Correct the endian of the checksum

On Mon, Feb 05, 2024 at 04:02:28PM +0800, Jacky Chou wrote: > There is no need to perform the endian twice here. > > Signed-off-by: Jacky Chou Reviewed-by: Dan Carpenter Fixes: f641a8ac93e0 ("phy: Add support for the NC-SI protocol") How did this ever work? Was this always tested on big endia

[PATCH] net: phy: ncsi: Correct the endian of the checksum

There is no need to perform the endian twice here. Signed-off-by: Jacky Chou --- drivers/net/phy/ncsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/ncsi.c b/drivers/net/phy/ncsi.c index eb3fd65bb4..74c5386d2e 100644 --- a/drivers/net/phy/ncsi.c +++ b/drive