Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-20 Thread Tom Rini
On Fri, Nov 19, 2021 at 01:30:06PM +0100, Michal Simek wrote: > Hi, > > On 11/18/21 20:54, Tom Rini wrote: > > On Thu, Nov 18, 2021 at 08:04:22PM +0100, Wolfgang Denk wrote: > > > Dear Tom, > > > > > > In message <2028162920.GH24579@bill-the-cat> you wrote: > > > > > > > > > It is perfectly

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-19 Thread Michal Simek
Hi, On 11/18/21 20:54, Tom Rini wrote: On Thu, Nov 18, 2021 at 08:04:22PM +0100, Wolfgang Denk wrote: Dear Tom, In message <2028162920.GH24579@bill-the-cat> you wrote: It is perfectly OK for U-Boot to start with a random MAC address, use this for a while, and change it so something else

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-18 Thread Tom Rini
On Thu, Nov 18, 2021 at 08:04:22PM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2028162920.GH24579@bill-the-cat> you wrote: > > > > > It is perfectly OK for U-Boot to start with a random MAC address, > > > use this for a while, and change it so something else later. This > > > is

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-18 Thread Wolfgang Denk
Dear Tom, In message <2028162920.GH24579@bill-the-cat> you wrote: > > > It is perfectly OK for U-Boot to start with a random MAC address, > > use this for a while, and change it so something else later. This > > is what may happen at production: say the MAC address is stored in > > some EEPR

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-18 Thread Tom Rini
On Thu, Nov 18, 2021 at 08:08:14AM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2027161545.GA24579@bill-the-cat> you wrote: > > > > Yes, you're changing behavior by requiring this change, and fwiw I > > suggested a slightly different fix-up here of deleting the device tree > > prop

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-18 Thread Tom Rini
On Thu, Nov 18, 2021 at 10:46:28AM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <1889944.1637219...@gemini.denx.de> I wrote: > > > > > We're about to > > > introduce the 3rd variant. I'd feel a whole lot better about taking in > > > a v2 of this patch that correct the help (and maybe up

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-18 Thread Wolfgang Denk
Dear Tom, In message <1889944.1637219...@gemini.denx.de> I wrote: > > > We're about to > > introduce the 3rd variant. I'd feel a whole lot better about taking in > > a v2 of this patch that correct the help (and maybe updates > > doc/README.enetaddr!) if someone could report back on what's going

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Wolfgang Denk
Dear Tom, In message <2027161545.GA24579@bill-the-cat> you wrote: > > Yes, you're changing behavior by requiring this change, and fwiw I > suggested a slightly different fix-up here of deleting the device tree > properties if it's a random MAC, in Michael's patch just disabling the > feature

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Tom Rini
On Wed, Nov 17, 2021 at 04:56:27PM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2027123548.GX24579@bill-the-cat> you wrote: > > > > > Why would you expect any "do not use" note? Locally adminitered MAC > > > addresses (even when randomly chosen) have been created for good > > > re

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Wolfgang Denk
Dear Tom, In message <2027123548.GX24579@bill-the-cat> you wrote: > > > Why would you expect any "do not use" note? Locally adminitered MAC > > addresses (even when randomly chosen) have been created for good > > reason, so they should be usable. > > Because as been noted in either this thre

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Tom Rini
On Wed, Nov 17, 2021 at 01:24:58PM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2027115025.GV24579@bill-the-cat> you wrote: > > > > > If the MAC address is not placed in the environment, then how can a > > > user query the currently used MAC address? All documentation says > > > b

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Wolfgang Denk
Dear Tom, In message <2027115025.GV24579@bill-the-cat> you wrote: > > > If the MAC address is not placed in the environment, then how can a > > user query the currently used MAC address? All documentation says > > basically: run "printenv ethaddr". > > Update the documentation and say to use

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-17 Thread Tom Rini
On Wed, Nov 17, 2021 at 08:44:52AM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2026184146.GF24579@bill-the-cat> you wrote: > > > > Because honestly, the more I read this, the more I think > > https://patchwork.ozlabs.org/project/uboot/patch/2025121152.3470910-1-m= > > ich...@w

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-16 Thread Wolfgang Denk
Dear Tom, In message <2026184146.GF24579@bill-the-cat> you wrote: > > Because honestly, the more I read this, the more I think > https://patchwork.ozlabs.org/project/uboot/patch/2025121152.3470910-1-m= > ich...@walle.cc/ > is essentially the right direction. There's no reason for 'net li

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-16 Thread Tom Rini
On Tue, Nov 16, 2021 at 03:56:45PM +0100, Wolfgang Denk wrote: > Dear Tom, > > In message <2026141855.GD24579@bill-the-cat> you wrote: > > > > So, to quote lib/Kconfig: > > config NET_RANDOM_ETHADDR > > bool "Random ethaddr if unset" > > help > > Selecting this will

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-16 Thread Wolfgang Denk
Dear Tom, In message <2026141855.GD24579@bill-the-cat> you wrote: > > So, to quote lib/Kconfig: > config NET_RANDOM_ETHADDR > bool "Random ethaddr if unset" > help > Selecting this will allow the Ethernet interface to function > even when the ethaddr variab

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-16 Thread Tom Rini
On Thu, Nov 11, 2021 at 10:10:57AM +0100, Michael Walle wrote: > Hi Ramon, > > Am 2021-11-09 14:55, schrieb Michael Walle: > > Am 2021-11-04 22:00, schrieb Ramon Fried: > > > > > What's the verdict ? We're keeping this patch ? > > > > There was a good point from Grygorii: linux might deal > > in

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-11 Thread Michael Walle
Hi Ramon, Am 2021-11-09 14:55, schrieb Michael Walle: Am 2021-11-04 22:00, schrieb Ramon Fried: What's the verdict ? We're keeping this patch ? There was a good point from Grygorii: linux might deal in its own way with missing ethernet addresses (and warn the user about it because its usuall

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-09 Thread Michael Walle
Am 2021-11-04 22:00, schrieb Ramon Fried: What's the verdict ? We're keeping this patch ? There was a good point from Grygorii: linux might deal in its own way with missing ethernet addresses (and warn the user about it because its usually an error). And IMHO that net list can be fixed in a d

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Ramon Fried
On Thu, Nov 4, 2021 at 3:40 PM Michael Walle wrote: > > Am 2021-11-04 14:15, schrieb Michal Simek: > > On 11/4/21 13:27, Michael Walle wrote: > >> Am 2021-11-04 12:16, schrieb Michal Simek: > >>> On 11/4/21 03:09, Grygorii Strashko wrote: > > > On 02/11/2021 12:27, Michal Simek wrot

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michael Walle
Am 2021-11-04 14:15, schrieb Michal Simek: On 11/4/21 13:27, Michael Walle wrote: Am 2021-11-04 12:16, schrieb Michal Simek: On 11/4/21 03:09, Grygorii Strashko wrote: On 02/11/2021 12:27, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Si

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michal Simek
On 11/4/21 13:27, Michael Walle wrote: Am 2021-11-04 12:16, schrieb Michal Simek: On 11/4/21 03:09, Grygorii Strashko wrote: On 02/11/2021 12:27, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is random

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michal Simek
On 11/4/21 13:59, Tom Rini wrote: On Thu, Nov 04, 2021 at 12:43:11PM +0100, Michal Simek wrote: On 11/4/21 12:37, Tom Rini wrote: On Thu, Nov 04, 2021 at 12:18:46PM +0100, Michal Simek wrote: On 11/3/21 17:57, Tom Rini wrote: On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Tom Rini
On Thu, Nov 04, 2021 at 12:43:11PM +0100, Michal Simek wrote: > > > On 11/4/21 12:37, Tom Rini wrote: > > On Thu, Nov 04, 2021 at 12:18:46PM +0100, Michal Simek wrote: > > > > > > > > > On 11/3/21 17:57, Tom Rini wrote: > > > > On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote: > > >

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michael Walle
Am 2021-11-04 12:16, schrieb Michal Simek: On 11/4/21 03:09, Grygorii Strashko wrote: On 02/11/2021 12:27, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is randomly generated it should be also saved to var

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michal Simek
On 11/4/21 12:37, Tom Rini wrote: On Thu, Nov 04, 2021 at 12:18:46PM +0100, Michal Simek wrote: On 11/3/21 17:57, Tom Rini wrote: On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote:

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Tom Rini
On Thu, Nov 04, 2021 at 12:18:46PM +0100, Michal Simek wrote: > > > On 11/3/21 17:57, Tom Rini wrote: > > On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote: > > > > > > > > > On 11/2/21 10:00, Michael Walle wrote: > > > > > On Fri, Oct 29, 2021 at 2:14 PM Michal Simek > > > > > wro

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michal Simek
On 11/3/21 17:57, Tom Rini wrote: On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is randomly generated it should be also saved to variables. This step is there when

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-04 Thread Michal Simek
On 11/4/21 03:09, Grygorii Strashko wrote: On 02/11/2021 12:27, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is randomly generated it should be also saved to variables. This step is there when MAC addre

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-03 Thread Grygorii Strashko
On 02/11/2021 12:27, Michal Simek wrote: On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is randomly generated it should be also saved to variables. This step is there when MAC address is passed via pdata but not when it is rand

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-03 Thread Tom Rini
On Tue, Nov 02, 2021 at 11:27:22AM +0100, Michal Simek wrote: > > > On 11/2/21 10:00, Michael Walle wrote: > > > On Fri, Oct 29, 2021 at 2:14 PM Michal Simek > > > wrote: > > > > > > > > When MAC address is randomly generated it should be also saved to > > > > variables. This step is there whe

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-02 Thread Michal Simek
On 11/2/21 10:00, Michael Walle wrote: On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: When MAC address is randomly generated it should be also saved to variables. This step is there when MAC address is passed via pdata but not when it is randomly generated. Signed-off-by: Michal Simek

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-02 Thread Michael Walle
> On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: >> >> When MAC address is randomly generated it should be also saved to >> variables. This step is there when MAC address is passed via pdata but not >> when it is randomly generated. >> >> Signed-off-by: Michal Simek >> --- >> >> net/eth-ucl

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-01 Thread Ramon Fried
On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: > > When MAC address is randomly generated it should be also saved to > variables. This step is there when MAC address is passed via pdata but not > when it is randomly generated. > > Signed-off-by: Michal Simek > --- > > net/eth-uclass.c | 2 +

[PATCH] net: uclass: Save ethernet MAC address when generated

2021-10-29 Thread Michal Simek
When MAC address is randomly generated it should be also saved to variables. This step is there when MAC address is passed via pdata but not when it is randomly generated. Signed-off-by: Michal Simek --- net/eth-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/eth-uclass.c b/n