Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-18 Thread Sergei Antonov
On Tue, 17 Jan 2023 at 19:14, Andre Przywara wrote: > > On Tue, 17 Jan 2023 16:12:54 +0300 > Sergei Antonov wrote: > > Hi Sergei, > > > On Tue, 17 Jan 2023 at 15:10, Andre Przywara wrote: > > > > > -#if CONFIG_IS_ENABLED(DM_SERIAL) && !defined(CONFIG_SYS_NS16550_REG_SIZE) > > > +#if CONFIG_IS_EN

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Andre Przywara
On Tue, 17 Jan 2023 17:23:57 -0500 Tom Rini wrote: > On Tue, Jan 17, 2023 at 10:15:46PM +, Andre Przywara wrote: > > On Tue, 17 Jan 2023 11:14:35 -0500 > > Tom Rini wrote: > > > > > On Tue, Jan 17, 2023 at 04:09:14PM +, Andre Przywara wrote: > > > > On Tue, 17 Jan 2023 08:15:18 -050

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Tom Rini
On Tue, Jan 17, 2023 at 10:15:46PM +, Andre Przywara wrote: > On Tue, 17 Jan 2023 11:14:35 -0500 > Tom Rini wrote: > > > On Tue, Jan 17, 2023 at 04:09:14PM +, Andre Przywara wrote: > > > On Tue, 17 Jan 2023 08:15:18 -0500 > > > Tom Rini wrote: > > > > > > Hi Tom, > > > > > > > On Tue

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Andre Przywara
On Tue, 17 Jan 2023 11:14:35 -0500 Tom Rini wrote: > On Tue, Jan 17, 2023 at 04:09:14PM +, Andre Przywara wrote: > > On Tue, 17 Jan 2023 08:15:18 -0500 > > Tom Rini wrote: > > > > Hi Tom, > > > > > On Tue, Jan 17, 2023 at 12:09:38PM +, Andre Przywara wrote: > > > > > > > Commit 95

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Tom Rini
On Tue, Jan 17, 2023 at 04:12:54PM +0300, Sergei Antonov wrote: > On Tue, 17 Jan 2023 at 15:10, Andre Przywara wrote: > > > -#if CONFIG_IS_ENABLED(DM_SERIAL) && !defined(CONFIG_SYS_NS16550_REG_SIZE) > > +#if CONFIG_IS_ENABLED(DM_SERIAL) > > /* > > * For driver model we always use one byte per

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Tom Rini
On Tue, Jan 17, 2023 at 04:09:14PM +, Andre Przywara wrote: > On Tue, 17 Jan 2023 08:15:18 -0500 > Tom Rini wrote: > > Hi Tom, > > > On Tue, Jan 17, 2023 at 12:09:38PM +, Andre Przywara wrote: > > > > > Commit 9591b63531fa ("Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig") > > > move

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Andre Przywara
On Tue, 17 Jan 2023 16:12:54 +0300 Sergei Antonov wrote: Hi Sergei, > On Tue, 17 Jan 2023 at 15:10, Andre Przywara wrote: > > > -#if CONFIG_IS_ENABLED(DM_SERIAL) && !defined(CONFIG_SYS_NS16550_REG_SIZE) > > +#if CONFIG_IS_ENABLED(DM_SERIAL) > > /* > > * For driver model we always use one by

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Andre Przywara
On Tue, 17 Jan 2023 08:15:18 -0500 Tom Rini wrote: Hi Tom, > On Tue, Jan 17, 2023 at 12:09:38PM +, Andre Przywara wrote: > > > Commit 9591b63531fa ("Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig") > > moved some NS16550 configuration variables into Kconfig. > > Among those there is CONF

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Tom Rini
On Tue, Jan 17, 2023 at 08:15:18AM -0500, Tom Rini wrote: > On Tue, Jan 17, 2023 at 12:09:38PM +, Andre Przywara wrote: > > > Commit 9591b63531fa ("Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig") > > moved some NS16550 configuration variables into Kconfig. > > Among those there is CONFIG_S

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Tom Rini
On Tue, Jan 17, 2023 at 12:09:38PM +, Andre Przywara wrote: > Commit 9591b63531fa ("Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig") > moved some NS16550 configuration variables into Kconfig. > Among those there is CONFIG_SYS_NS16550_REG_SIZE, which used to be only > defined for SPL build r

Re: [PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Sergei Antonov
On Tue, 17 Jan 2023 at 15:10, Andre Przywara wrote: > -#if CONFIG_IS_ENABLED(DM_SERIAL) && !defined(CONFIG_SYS_NS16550_REG_SIZE) > +#if CONFIG_IS_ENABLED(DM_SERIAL) > /* > * For driver model we always use one byte per register, and sort out the > * differences in the driver > */ > +#undef

[PATCH] ns16550: Fix DM serial operation with non-DM SPL

2023-01-17 Thread Andre Przywara
Commit 9591b63531fa ("Convert CONFIG_SYS_NS16550_MEM32 et al to Kconfig") moved some NS16550 configuration variables into Kconfig. Among those there is CONFIG_SYS_NS16550_REG_SIZE, which used to be only defined for SPL build runs, but now is always set (thanks for Kconfig). However this breaks the