[PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-06 Thread Icenowy Zheng
The OHCI and EHCI controllers are both bound to the same PHY. They will both do init and power_on operations when the controller is brought up and both do power_off and exit when the controller is stopped. However, the PHY uclass of U-Boot is not as sane as we thought -- they won't maintain a statu

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-10-23 Thread Icenowy Zheng
在 2021-10-23星期六的 13:23 -0400,Siva Mahadevan写道: > Icenowy Zheng wrote: > > The OHCI and EHCI controllers are both bound to the same PHY. They > > will > > both do init and power_on operations when the controller is brought > > up > > and both do power_off and exit when the controller is stopped. > >

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-10-23 Thread Siva Mahadevan
Icenowy Zheng wrote: > The OHCI and EHCI controllers are both bound to the same PHY. They will > both do init and power_on operations when the controller is brought up > and both do power_off and exit when the controller is stopped. However, > the PHY uclass of U-Boot is not as sane as we thought -

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-11-12 Thread Simon Glass
Hi, On Sat, 23 Oct 2021 at 12:19, Icenowy Zheng wrote: > > 在 2021-10-23星期六的 13:23 -0400,Siva Mahadevan写道: > > Icenowy Zheng wrote: > > > The OHCI and EHCI controllers are both bound to the same PHY. They > > > will > > > both do init and power_on operations when the controller is brought > > > up

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-07-02 Thread Grant Likely
On Wed, Apr 7, 2021 at 8:32 AM Icenowy Zheng wrote: > > > > 于 2021年4月7日 GMT+08:00 下午3:28:53, Frank Wang 写到: > >Hi, > > > > > >On 2021/4/7 14:43, Icenowy Zheng wrote: > >> > >> 于 2021年4月7日 GMT+08:00 下午2:42:34, Frank Wang > > 写到: > >>> Hi Icenowy Zheng, > >>> > >>> In my view, it is better to imple

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-06 Thread Peter Robinson
On Tue, Apr 6, 2021 at 4:11 PM Icenowy Zheng wrote: > > The OHCI and EHCI controllers are both bound to the same PHY. They will > both do init and power_on operations when the controller is brought up > and both do power_off and exit when the controller is stopped. However, > the PHY uclass of U-B

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-06 Thread Frank Wang
Hi Icenowy Zheng, In my view, it is better to implement this mechanism in phy-uclass which resemble Linux Kernel have implemented that can avoid do duplication of work in each SoC's PHY driver. BR. Frank On 2021/4/6 23:10, Icenowy Zheng wrote: The OHCI and EHCI controllers are both bound t

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-06 Thread Icenowy Zheng
于 2021年4月7日 GMT+08:00 下午2:42:34, Frank Wang 写到: >Hi Icenowy Zheng, > >In my view, it is better to implement this mechanism in phy-uclass >which >resemble Linux Kernel have implemented that can avoid do duplication of > >work in each SoC's PHY driver. I'm afraid of breaking existing drivers wh

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-07 Thread Frank Wang
Hi, On 2021/4/7 14:43, Icenowy Zheng wrote: 于 2021年4月7日 GMT+08:00 下午2:42:34, Frank Wang 写到: Hi Icenowy Zheng, In my view, it is better to implement this mechanism in phy-uclass which resemble Linux Kernel have implemented that can avoid do duplication of work in each SoC's PHY driver. I'm

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-04-07 Thread Icenowy Zheng
于 2021年4月7日 GMT+08:00 下午3:28:53, Frank Wang 写到: >Hi, > > >On 2021/4/7 14:43, Icenowy Zheng wrote: >> >> 于 2021年4月7日 GMT+08:00 下午2:42:34, Frank Wang > 写到: >>> Hi Icenowy Zheng, >>> >>> In my view, it is better to implement this mechanism in phy-uclass >>> which >>> resemble Linux Kernel have imp