Re: [PATCH] pinctrl: mediatek: set R1/R0 in case pullen/pullsel succeeded

On Wed, Apr 12, 2023 at 09:36:43PM +0100, Daniel Golle wrote: > Commit dafe0fbfb0f3 ("pinctrl: mediatek: rewrite mtk_pinconf_set and > related functions") changed the logic deciding to set R0 and R1 > registers for V1 devices. > > Before: > /* Also set PUPD/R0/R1 if the pin has them */ >

Aw: [PATCH] pinctrl: mediatek: set R1/R0 in case pullen/pullsel succeeded

FYI...this issue affects only specific eMMC-Chips (vendor SEC) on the Bananapi-R2 (v1.2). i have a v1.1 with a Samsung eMMC where i had no problems with the missing pullups/pulldowns (maybe this has internal resistors) more information about this special case: https://forum.banana-pi.org/t/prob

[PATCH] pinctrl: mediatek: set R1/R0 in case pullen/pullsel succeeded

Commit dafe0fbfb0f3 ("pinctrl: mediatek: rewrite mtk_pinconf_set and related functions") changed the logic deciding to set R0 and R1 registers for V1 devices. Before: /* Also set PUPD/R0/R1 if the pin has them */ err = mtk_hw_set_value(dev, pin, PINCTRL_PIN_REG_PUPD, !pullup);