Re: [PATCH] rockchip: i2c: fix switch to new implementation for rk3188

2020-06-28 Thread Heiko Schocher
Hi Alex, Am 29.06.2020 um 05:23 schrieb David Wu: Hi Alexander, Thank you for your patch, the grf header file is missing for rk3066, the GRF_SOC_CON1 offset of 3066 is 0x154, the corresponding bit of i2c0~i2c4 is also bit11 ~ bit15. There is currently no support for rk3066 at mainline,

Re: [PATCH] rockchip: i2c: fix switch to new implementation for rk3188

2020-06-28 Thread David Wu
Hi Alexander, Thank you for your patch, the grf header file is missing for rk3066, the GRF_SOC_CON1 offset of 3066 is 0x154, the corresponding bit of i2c0~i2c4 is also bit11 ~ bit15. There is currently no support for rk3066 at mainline, rk3066 is not handled here, I think it’s okay, so,

Re: [PATCH] rockchip: i2c: fix switch to new implementation for rk3188

2020-06-27 Thread Alexander Kochetkov
To make clear, there is kernel driver i2c-rk3x.c. For rk3066 it write bits in the GRF word at offset 0x154. See [1] and [2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/busses/i2c-rk3x.c#n1236 [2]

Re: [PATCH] rockchip: i2c: fix switch to new implementation for rk3188

2020-06-27 Thread Kever Yang
+David, Hi David,     Could you help to commend on this? Hi Alex,     Thanks for your patch. On 2020/6/22 下午9:06, Alexander Kochetkov wrote: The commit e7ae4cf27a6d 'pinctrl: rockchip: Add common rockchip pinctrl driver' dropped rk3188_pinctrl_request operation, that did switching to new

[PATCH] rockchip: i2c: fix switch to new implementation for rk3188

2020-06-22 Thread Alexander Kochetkov
The commit e7ae4cf27a6d 'pinctrl: rockchip: Add common rockchip pinctrl driver' dropped rk3188_pinctrl_request operation, that did switching to new implementation. This commit implement switching to new implementation using writing bits to GRF. I don't have rk3060 board to test, so switching