Re: [PATCH] serial: ns16550: Handle zero value

2021-02-06 Thread Simon Glass
Hi Simon, On Thu, Feb 4, 2021 at 8:33 AM Simon Glass wrote: > > On Wed, 3 Feb 2021 at 17:20, Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > > > > > A working device

Re: [PATCH] serial: ns16550: Handle zero value

2021-02-03 Thread Bin Meng
Hi Simon, On Thu, Feb 4, 2021 at 8:33 AM Simon Glass wrote: > > On Wed, 3 Feb 2021 at 17:20, Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > > > > > A working device

Re: [PATCH] serial: ns16550: Handle zero value

2021-02-03 Thread Simon Glass
On Wed, 3 Feb 2021 at 17:20, Bin Meng wrote: > > Hi Simon, > > On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > > > A working device tree node of ns16550 should never be populated > > > with value zero for the propert

Re: [PATCH] serial: ns16550: Handle zero value

2021-02-03 Thread Bin Meng
Hi Simon, On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > Hi Bin, > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > A working device tree node of ns16550 should never be populated > > with value zero for the property. Unfortunately > > this is the case for the QEMU ppce500 target.

Re: [PATCH] serial: ns16550: Handle zero value

2021-02-03 Thread Simon Glass
Hi Bin, On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > A working device tree node of ns16550 should never be populated > with value zero for the property. Unfortunately > this is the case for the QEMU ppce500 target. > > Let's try to assign plat->clock to CONFIG_SYS_NS16550_CLK as the > last r

[PATCH] serial: ns16550: Handle zero value

2021-02-03 Thread Bin Meng
A working device tree node of ns16550 should never be populated with value zero for the property. Unfortunately this is the case for the QEMU ppce500 target. Let's try to assign plat->clock to CONFIG_SYS_NS16550_CLK as the last resort to handle such case. This commit should be reverted when: -