Re: [PATCH] smbios: Fix SMBIOS tables

2021-06-27 Thread Simon Glass
Hi Ilias, On Sat, 26 Jun 2021 at 12:51, Ilias Apalodimas wrote: > > Hi Simon, > > > > --- > [...] > > > This depends on > > > https://lists.denx.de/pipermail/u-boot/2021-June/451761.html > > > lib/smbios.c | 10 ++ > > > 1 file changed, 10 insertions(+) > > > > It is strange that all

Re: [PATCH] smbios: Fix SMBIOS tables

2021-06-26 Thread Ilias Apalodimas
Hi Simon, > > --- [...] > > This depends on https://lists.denx.de/pipermail/u-boot/2021-June/451761.html > > lib/smbios.c | 10 ++ > > 1 file changed, 10 insertions(+) > > It is strange that all the boards that defined the old CONFIG set it > to "", meaning that an empty string is

Re: [PATCH] smbios: Fix SMBIOS tables

2021-06-26 Thread Simon Glass
Hi Ilias, On Thu, 10 Jun 2021 at 03:33, Ilias Apalodimas wrote: > > Commit e4f8e543f1a9("smbios: Drop the unused Kconfig options") > break SMBIOS tables. The reason is that the patch drops the Kconfig > options *after* removing the code using them, but that changes the semantics > of the code

Re: [PATCH] smbios: Fix SMBIOS tables

2021-06-10 Thread Heinrich Schuchardt
On 6/10/21 11:33 AM, Ilias Apalodimas wrote: Commit e4f8e543f1a9("smbios: Drop the unused Kconfig options") break SMBIOS tables. The reason is that the patch drops the Kconfig options *after* removing the code using them, but that changes the semantics of the code completely. Prior to the

[PATCH] smbios: Fix SMBIOS tables

2021-06-10 Thread Ilias Apalodimas
Commit e4f8e543f1a9("smbios: Drop the unused Kconfig options") break SMBIOS tables. The reason is that the patch drops the Kconfig options *after* removing the code using them, but that changes the semantics of the code completely. Prior to the change a non NULL value was used in the 'product'