Re: [PATCH] spl: Jump to image at end of board_init_r

2023-10-10 Thread Tom Rini
On Wed, Sep 27, 2023 at 09:44:13PM +, Jonas Karlman wrote: > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > optee, opensbi or linux images. > > Jump to image at the end of board_init_r() to fix this. > > Signed-off-by: Jonas Karlman > Reviewed-by: Simon Glass

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Tom Rini
On Fri, Sep 29, 2023 at 07:56:49AM -0400, Tom Rini wrote: > On Fri, Sep 29, 2023 at 02:57:42AM +0200, Heinrich Schuchardt wrote: > > On 9/27/23 23:44, Jonas Karlman wrote: > > > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > > > optee, opensbi or linux images. > > > > >

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Heinrich Schuchardt
On 29.09.23 13:56, Tom Rini wrote: On Fri, Sep 29, 2023 at 02:57:42AM +0200, Heinrich Schuchardt wrote: On 9/27/23 23:44, Jonas Karlman wrote: spl_board_prepare_for_boot() is not called before jumping/invoking atf, optee, opensbi or linux images. Jump to image at the end of board_init_r() to

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Tom Rini
On Fri, Sep 29, 2023 at 02:57:42AM +0200, Heinrich Schuchardt wrote: > On 9/27/23 23:44, Jonas Karlman wrote: > > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > > optee, opensbi or linux images. > > > > Jump to image at the end of board_init_r() to fix this. > > > >

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
> We should understand the implications of your patch on the code size. If > it leads to binary code growth, we should evaluate alternatives. This is not my patch, but Jonas'. But sure. Cheers.

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Heinrich Schuchardt
On 9/29/23 09:55, Ferass El Hafidi wrote: Hi Heinrich, On Fri Sep 29, 2023 at 2:57 AM CEST, Heinrich Schuchardt wrote: In SPL we are fighting for every byte of binary size. What is the impact of this change on the code size? I would expect that your increasing it; especially if only one of

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
On Fri Sep 29, 2023 at 1:42 AM CEST, Simon Glass wrote: > On Wed, 27 Sept 2023 at 15:44, Jonas Karlman wrote: > > > > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > > optee, opensbi or linux images. > > > > Jump to image at the end of board_init_r() to fix this. > > > >

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
Hi Heinrich, On Fri Sep 29, 2023 at 2:57 AM CEST, Heinrich Schuchardt wrote: > In SPL we are fighting for every byte of binary size. > > What is the impact of this change on the code size? > > I would expect that your increasing it; especially if only one of the > CONFIG_OPTIONS is enabled. > >

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-28 Thread Heinrich Schuchardt
On 9/27/23 23:44, Jonas Karlman wrote: spl_board_prepare_for_boot() is not called before jumping/invoking atf, optee, opensbi or linux images. Jump to image at the end of board_init_r() to fix this. Signed-off-by: Jonas Karlman --- This patch have dependencies on the following patches: spl:

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-28 Thread Simon Glass
On Wed, 27 Sept 2023 at 15:44, Jonas Karlman wrote: > > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > optee, opensbi or linux images. > > Jump to image at the end of board_init_r() to fix this. > > Signed-off-by: Jonas Karlman > --- > This patch have dependencies on

[PATCH] spl: Jump to image at end of board_init_r

2023-09-28 Thread Jonas Karlman
spl_board_prepare_for_boot() is not called before jumping/invoking atf, optee, opensbi or linux images. Jump to image at the end of board_init_r() to fix this. Signed-off-by: Jonas Karlman --- This patch have dependencies on the following patches: spl: add __noreturn attribute to