Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Marek Vasut
On 1/20/23 18:26, Niel Fourie wrote: Hi Marek Hi, On 18/12/2022 02:51, Marek Vasut wrote: On 12/16/22 17:35, lu...@denx.de wrote: Hi Marek, Hi, [...] Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()" be dropped ? It seems this patch fully replaces it. Th

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2023-01-20 Thread Niel Fourie
Hi Marek On 18/12/2022 02:51, Marek Vasut wrote: On 12/16/22 17:35, lu...@denx.de wrote: Hi Marek, Hi, [...] Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()" be dropped ? It seems this patch fully replaces it. That old patch only exists for in case there we

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-17 Thread Marek Vasut
On 12/16/22 17:35, lu...@denx.de wrote: Hi Marek, Hi, [...] Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in eth_halt()" be dropped ? It seems this patch fully replaces it. That old patch only exists for in case there were showstopper issues with the new patch which I m

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-17 Thread Marek Vasut
On 12/12/22 16:29, Niel Fourie wrote: [...] +static int _usb_eth_start(struct ether_priv *priv) +{ + unsigned long ts; + unsigned long timeout = USB_CONNECT_TIMEOUT; + struct eth_dev *dev = &priv->ethdev; + + if (!dev->gadget) + return -1; + dev->network

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-16 Thread lusus
Hi Marek, On 2022-12-15 06:58, Marek Vasut wrote: On 12/13/22 12:01, Niel Fourie wrote: Hi Marek, Hi, On 12/12/2022 17:46, Marek Vasut wrote: On 12/12/22 16:29, Niel Fourie wrote: Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init()

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-14 Thread Marek Vasut
On 12/13/22 12:01, Niel Fourie wrote: Hi Marek, Hi, On 12/12/2022 17:46, Marek Vasut wrote: On 12/12/22 16:29, Niel Fourie wrote: Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, wh

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-13 Thread Niel Fourie
Hi Marek, On 12/12/2022 17:46, Marek Vasut wrote: On 12/12/22 16:29, Niel Fourie wrote: Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, which _usb_eth_halt() reverses, and together are

Re: [PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-12 Thread Marek Vasut
On 12/12/22 16:29, Niel Fourie wrote: Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, which _usb_eth_halt() reverses, and together are used for probing and removing the device. The _usb_

[PATCH] usb: gadget: ether: split start/stop from init/halt

2022-12-12 Thread Niel Fourie
Split out _usb_eth_start() from _usb_eth_init() and usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only initialises and registers the gadget device, which _usb_eth_halt() reverses, and together are used for probing and removing the device. The _usb_eth_start() and _usb_eth_stop() function