Hi Simon,
On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
>
> At present we query the memory map on boards which don't support it. Fix
> this by only doing it on Apollo Lake.
>
> This fixes booting on chromebook_link.
>
> Signed-off-by: Simon Glass
> Fixes: 92842147c31 ("spi: ich: Add
Hi Simon,
On Mon, Apr 20, 2020 at 3:14 AM Simon Glass wrote:
>
> Hi Bin,
>
> On Tue, 31 Mar 2020 at 07:16, Simon Glass wrote:
> >
> > Hi Bin,
> >
> > On Tue, 31 Mar 2020 at 03:50, Bin Meng wrote:
> > >
> > > Hi Simon,
> > >
> > > On Tue, Mar 31, 2020 at 7:57 AM Simon Glass wrote:
> > > >
> >
Hi Bin,
On Tue, 31 Mar 2020 at 07:16, Simon Glass wrote:
>
> Hi Bin,
>
> On Tue, 31 Mar 2020 at 03:50, Bin Meng wrote:
> >
> > Hi Simon,
> >
> > On Tue, Mar 31, 2020 at 7:57 AM Simon Glass wrote:
> > >
> > > Hi Bin,
> > >
> > > On Mon, 30 Mar 2020 at 03:42, Bin Meng wrote:
> > > >
> > > > Hi
Hi Bin,
On Tue, 31 Mar 2020 at 03:50, Bin Meng wrote:
>
> Hi Simon,
>
> On Tue, Mar 31, 2020 at 7:57 AM Simon Glass wrote:
> >
> > Hi Bin,
> >
> > On Mon, 30 Mar 2020 at 03:42, Bin Meng wrote:
> > >
> > > Hi Simon,
> > >
> > > On Sun, Mar 29, 2020 at 4:58 AM Simon Glass wrote:
> > > >
> > > >
Hi Simon,
On Tue, Mar 31, 2020 at 7:57 AM Simon Glass wrote:
>
> Hi Bin,
>
> On Mon, 30 Mar 2020 at 03:42, Bin Meng wrote:
> >
> > Hi Simon,
> >
> > On Sun, Mar 29, 2020 at 4:58 AM Simon Glass wrote:
> > >
> > > Hi Bin,
> > >
> > > On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote:
> > > >
> > > >
Hi Bin,
On Mon, 30 Mar 2020 at 03:42, Bin Meng wrote:
>
> Hi Simon,
>
> On Sun, Mar 29, 2020 at 4:58 AM Simon Glass wrote:
> >
> > Hi Bin,
> >
> > On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote:
> > >
> > > Hi Simon,
> > >
> > > On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote:
> > > >
> > >
Hi Simon,
On Sun, Mar 29, 2020 at 4:58 AM Simon Glass wrote:
>
> Hi Bin,
>
> On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote:
> >
> > Hi Simon,
> >
> > On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote:
> > >
> > > HI Bin,
> > >
> > > On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote:
> > > >
> > >
Hi Bin,
On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote:
>
> Hi Simon,
>
> On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote:
> >
> > HI Bin,
> >
> > On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote:
> > >
> > > Hi Simon,
> > >
> > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
> > > >
> > >
Hi Bin,
On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote:
>
> Hi Simon,
>
> On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote:
> >
> > HI Bin,
> >
> > On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote:
> > >
> > > Hi Simon,
> > >
> > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
> > > >
> >
Hi Simon,
On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote:
>
> HI Bin,
>
> On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote:
> >
> > Hi Simon,
> >
> > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
> > >
> > > At present we query the memory map on boards which don't support it. Fix
> > >
HI Bin,
On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote:
>
> Hi Simon,
>
> On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
> >
> > At present we query the memory map on boards which don't support it. Fix
> > this by only doing it on Apollo Lake.
> >
>
> I wonder isn't this check already covered
Hi Simon,
On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote:
>
> At present we query the memory map on boards which don't support it. Fix
> this by only doing it on Apollo Lake.
>
I wonder isn't this check already covered in mrccache_get_region() below:
ret = dm_spi_get_mmap(dev, _base, _size,
At present we query the memory map on boards which don't support it. Fix
this by only doing it on Apollo Lake.
This fixes booting on chromebook_link.
Signed-off-by: Simon Glass
Fixes: 92842147c31 ("spi: ich: Add support for get_mmap() method")
---
drivers/spi/ich.c | 3 +++
1 file changed, 3
13 matches
Mail list logo