Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 09:05:33PM +0800, jihongbin wrote: > It may be that there are relatively few people using this function, or the > length of the transmitted data is less than 128byte * 255 byte, so the > triggering conditions for the above problems are not encountered; > > I actually

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Dan Carpenter
On Tue, Feb 06, 2024 at 09:05:33PM +0800, jihongbin wrote: > It may be that there are relatively few people using this function, or the > length of the transmitted data is less than 128byte * 255 byte, so the > triggering conditions for the above problems are not encountered; > > I actually

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread jihongbin
It may be that there are relatively few people using this function, or the length of the transmitted data is less than 128byte * 255 byte, so the triggering conditions for the above problems are not encountered; I actually discovered this problem during testing. Continuous transmission always

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread jihongbin
This is a duplicate, please ignore 在 2024/2/6 10:49, Hongbin Ji 写道: When the blk sequence number is 255 and cblk is 0, the original XOR condition produces a result of 0,and the judgment condition will be unsuccessful. Signed-off-by: Hongbin Ji --- common/xyzModem.c | 2 +- 1 file changed,

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-06 Thread Tom Rini
On Tue, Feb 06, 2024 at 10:49:25AM +0800, Hongbin Ji wrote: > When the blk sequence number is 255 and cblk is 0, the original XOR condition > produces a result of 0,and the judgment condition will be unsuccessful. > > Signed-off-by: Hongbin Ji > --- > common/xyzModem.c | 2 +- > 1 file

[PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-05 Thread Hongbin Ji
When the blk sequence number is 255 and cblk is 0, the original XOR condition produces a result of 0,and the judgment condition will be unsuccessful. Signed-off-by: Hongbin Ji --- common/xyzModem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/xyzModem.c

Re: [PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-05 Thread Dan Carpenter
On Mon, Feb 05, 2024 at 02:58:50PM +0800, Hongbin Ji wrote: > When the blk sequence number is 255 and cblk is 0, the original XOR condition > produces a result of 0,and the judgment condition will be unsuccessful. > This code is 18 years old so it's surprising that it's causing an issue now.

[PATCH] xyzModem: Correct xmodem blk verification conditions

2024-02-05 Thread Hongbin Ji
When the blk sequence number is 255 and cblk is 0, the original XOR condition produces a result of 0,and the judgment condition will be unsuccessful. Signed-off-by: Hongbin Ji --- common/xyzModem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/xyzModem.c