Re: [PATCH 0/2] Console/stdio use after free

2021-01-25 Thread Nicolas Saenz Julienne
Hi Andy, Simon On Wed, 2021-01-20 at 17:57 +0200, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 4:05 PM Nicolas Saenz Julienne > wrote: > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > introduces a use after free in usb_kbd_remove(): > > > > - usbkbd's stdio dev

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Simon Glass
Hi Pratyush, On Wed, 20 Jan 2021 at 11:59, Pratyush Yadav wrote: > > On 20/01/21 07:18AM, Simon Glass wrote: > > Hi Nicolas, > > > > On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne > > wrote: > > > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > > introduces a u

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Pratyush Yadav
On 20/01/21 07:18AM, Simon Glass wrote: > Hi Nicolas, > > On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne > wrote: > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > introduces a use after free in usb_kbd_remove(): > > > > - usbkbd's stdio device is de-registered

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Andy Shevchenko
On Wed, Jan 20, 2021 at 4:05 PM Nicolas Saenz Julienne wrote: > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > introduces a use after free in usb_kbd_remove(): > > - usbkbd's stdio device is de-registered with stdio_deregister_dev(), > the struct stdio_dev is freed. > > -

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Simon Glass
Hi Nicolas, On Wed, 20 Jan 2021 at 07:44, Nicolas Saenz Julienne wrote: > > On Wed, 2021-01-20 at 07:18 -0700, Simon Glass wrote: > > Hi Nicolas, > > > > On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne > > wrote: > > > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles')

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Nicolas Saenz Julienne
On Wed, 2021-01-20 at 07:18 -0700, Simon Glass wrote: > Hi Nicolas, > > On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne > wrote: > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > introduces a use after free in usb_kbd_remove(): > > > > - usbkbd's stdio device i

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Simon Glass
Hi Nicolas, On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne wrote: > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > introduces a use after free in usb_kbd_remove(): > > - usbkbd's stdio device is de-registered with stdio_deregister_dev(), > the struct stdio_dev is f

[PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Nicolas Saenz Julienne
With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') introduces a use after free in usb_kbd_remove(): - usbkbd's stdio device is de-registered with stdio_deregister_dev(), the struct stdio_dev is freed. - iomux_doenv() is called, usbkbd removed from the console list, and console