Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Josua Mayer
Hi Stefan, Thank you for starting to review this patchset! Am 03.05.22 um 09:09 schrieb Stefan Roese: Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that   reviewers have a summary of the changes. I have sent a cover-letter t

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Stefan Roese
Hi Josua, a few general comments about this series: - A cover letter for this patchset would be very helpful, so that reviewers have a summary of the changes. - Please Cc the original author of this code Baruch Siach in the next version as well (if there is next version that is). On 02.05.2

[PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Josua Mayer
Make tlv_eeprom command device selection an explicit parameter of all function calls. Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 50 ++-- include/tlv_eeprom.h | 3 ++- 2 files changed, 27 insertions(+), 26 deletions(-) diff --git a/cmd/tlv_eep