Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-23 Thread Köry Maincent
Hello Andre, On Tue, 23 Feb 2021 13:30:38 + Andre Przywara wrote: y extension_board_scan board specific function, would you prefer if I > > move to callback like below instead of Kconfig? > > > > if (of_machine_is_compatible("nextthing,chip")) > > extension_board_register_callback(chip_e

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-23 Thread Andre Przywara
On Mon, 22 Feb 2021 15:23:08 +0100 Köry Maincent wrote: Hi Köry, > Thanks for your reviews. > > On Fri, 19 Feb 2021 17:29:26 + > Andre Przywara wrote: > > > > > > > And then based on my comment in the previous patch, similar to > > > PINEPHONE_DT_SELECTION and other board-specific option

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-22 Thread Köry Maincent
Hi Tom, Andre Thanks for your reviews. On Fri, 19 Feb 2021 17:29:26 + Andre Przywara wrote: > > > > And then based on my comment in the previous patch, similar to > > PINEPHONE_DT_SELECTION and other board-specific options, add a > > CHIP_DIP_SCAN option or similar. > > Yes, indeed, tha

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-19 Thread Andre Przywara
On Fri, 19 Feb 2021 11:54:54 -0500 Tom Rini wrote: Hi, > On Thu, Feb 18, 2021 at 02:29:36PM +0100, Kory Maincent wrote: > > > Add the extension_board_scan specific function to scan the information > > of the EEPROM on one-wire and fill the extension struct. > > > > Signed-off-by: Kory Maincent

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-19 Thread Tom Rini
On Thu, Feb 18, 2021 at 02:29:36PM +0100, Kory Maincent wrote: > Add the extension_board_scan specific function to scan the information > of the EEPROM on one-wire and fill the extension struct. > > Signed-off-by: Kory Maincent > --- > arch/arm/mach-sunxi/Kconfig | 2 + > board/sunxi/Makefile

[PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-18 Thread Kory Maincent
Add the extension_board_scan specific function to scan the information of the EEPROM on one-wire and fill the extension struct. Signed-off-by: Kory Maincent --- arch/arm/mach-sunxi/Kconfig | 2 + board/sunxi/Makefile| 1 + board/sunxi/chip.c | 104 +++