Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Dragan Simic
On 2024-02-06 13:37, Quentin Schulz wrote: On 2/6/24 13:33, Dragan Simic wrote: On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39, Dragan Simic wrote: On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On 2024

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Quentin Schulz
Hi Dragan, On 2/6/24 13:33, Dragan Simic wrote: [Some people who received this message don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Quentin, On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39, Dra

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Dragan Simic
Hello Quentin, On 2024-02-06 13:26, Quentin Schulz wrote: On 2/4/24 11:39, Dragan Simic wrote: On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Si

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-06 Thread Quentin Schulz
Hi Dragan, Jonas, On 2/4/24 11:39, Dragan Simic wrote: [Some people who received this message don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Jonas, On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-04 Thread Dragan Simic
Hello Jonas, On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: We should add more ifdef guards to rockchip_setup_macaddr(), to prevent

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-04 Thread Jonas Karlman
On 2024-02-04 05:21, Dragan Simic wrote: > On 2024-02-03 16:18, Dragan Simic wrote: >> On 2024-02-03 15:18, Jonas Karlman wrote: >>> On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: > From: Quentin Schulz > >>>

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Jonas, On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use roc

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Jonas Karlman
Hi Dragan, On 2024-02-03 14:19, Dragan Simic wrote: > Hello Quentin, > > Please see my comments below. > > On 2024-01-23 15:49, Quentin Schulz wrote: >> From: Quentin Schulz >> >> Only setup_iodomain() differs from the original misc_init_r from >> Rockchip mach code, so let's use rockchip_early

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin, Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockch

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Signed-off-by: Quenti

[PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-01-23 Thread Quentin Schulz
From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- board/pine64/rockpro64_rk3399/r