Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-08-02 Thread Leo Liang
Hi Bin, On Mon, Aug 02, 2021 at 05:48:49PM +0800, Bin Meng wrote: > Hi Leo, > > On Mon, Aug 2, 2021 at 5:17 PM Leo Liang wrote: > > > > Hi Bin, > > On Mon, Aug 02, 2021 at 05:01:07PM +0800, Bin Meng wrote: > > > Hi Leo, > > > > > > On Mon, Aug 2, 2021 at 4:50 PM Leo Liang wrote: > > > > > > > >

Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-08-02 Thread Bin Meng
Hi Leo, On Mon, Aug 2, 2021 at 5:17 PM Leo Liang wrote: > > Hi Bin, > On Mon, Aug 02, 2021 at 05:01:07PM +0800, Bin Meng wrote: > > Hi Leo, > > > > On Mon, Aug 2, 2021 at 4:50 PM Leo Liang wrote: > > > > > > Hi Bin, > > > > > > On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote: > > > > On

Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-08-02 Thread Leo Liang
Hi Bin, On Mon, Aug 02, 2021 at 05:01:07PM +0800, Bin Meng wrote: > Hi Leo, > > On Mon, Aug 2, 2021 at 4:50 PM Leo Liang wrote: > > > > Hi Bin, > > > > On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote: > > > On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt > > > wrote: > > > > > > >

Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-08-02 Thread Bin Meng
Hi Leo, On Mon, Aug 2, 2021 at 4:50 PM Leo Liang wrote: > > Hi Bin, > > On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote: > > On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt > > wrote: > > > > > > > nits: missing > > Could you explain what is missing here? > I did not quite catch th

Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-08-02 Thread Leo Liang
Hi Bin, On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote: > On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt > wrote: > > > > nits: missing Could you explain what is missing here? I did not quite catch the point, thanks! > > From: Heinrich Schuchardt > > > We should not use /de

Re: [PATCH 1/1] doc: riscv: flashing SiFive boards

2021-07-28 Thread Bin Meng
On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt wrote: > nits: missing From: Heinrich Schuchardt > We should not use /dev/sda and /dev/sdb in our examples. Users might > inadvertently mess up their workstation. Use /dev/sdX instead. > > Remove console output like '# ' and '> ' which makes

[PATCH 1/1] doc: riscv: flashing SiFive boards

2021-07-28 Thread Heinrich Schuchardt
We should not use /dev/sda and /dev/sdb in our examples. Users might inadvertently mess up their workstation. Use /dev/sdX instead. Remove console output like '# ' and '> ' which makes copying hard. Set example language to bash for correct syntax-highlighting. Signed-off-by: Heinrich Schuchardt