Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-31 Thread Simon Glass
Hi, On Wed, 28 Jul 2021 at 23:13, Jonathan Gray wrote: > > On Wed, Jul 28, 2021 at 09:04:33PM +0300, Artem Panfilov wrote: > > Fix LibreSSL compilation for versions before v2.7.0. > > Why 2.7.0? I had to disable CONFIG_FIT_SIGNATURE to get the qemu > targets to build on OpenBSD-current (3.4.0) a

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-29 Thread Alex G.
Hi Artem On 7/29/21 9:52 AM, Artem Panfilov wrote: On 29.07.2021 15:59, Tom Rini wrote: Well yes, this is part of the question now, is there enough interest in the old version to bother with?  The other part of the question is what's being built now that wasn't being built before, and is that a

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-29 Thread Artem Panfilov
On 29.07.2021 15:59, Tom Rini wrote: > Well yes, this is part of the question now, is there enough interest in > the old version to bother with?  The other part of the question is > what's being built now that wasn't being built before, and is that a bug > or a feature (a less CONFIG-dependent set

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-29 Thread Tom Rini
On Thu, Jul 29, 2021 at 01:40:41PM +0300, Artem Panfilov wrote: > On 29.07.2021 02:43, Tom Rini wrote: > > > > Yes, true.  And that's two 1-line if/else.  That's a reasonable to me > > level of effort to keep supporting older hosts.  Your patch is adding in > > 60 lines.  I really do want to dig a

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-29 Thread Artem Panfilov
On 29.07.2021 02:43, Tom Rini wrote: > > Yes, true.  And that's two 1-line if/else.  That's a reasonable to me > level of effort to keep supporting older hosts.  Your patch is adding in > 60 lines.  I really do want to dig a bit more here. For me, it doesn't matter how many lines of code were adde

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Jonathan Gray
On Wed, Jul 28, 2021 at 09:04:33PM +0300, Artem Panfilov wrote: > Fix LibreSSL compilation for versions before v2.7.0. Why 2.7.0? I had to disable CONFIG_FIT_SIGNATURE to get the qemu targets to build on OpenBSD-current (3.4.0) as there is no BN_bn2binpad(). 2.7.0 is also over three years old at

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Tom Rini
On Thu, Jul 29, 2021 at 02:37:10AM +0300, Artem Panfilov wrote: > > On 29.07.2021 01:56, Tom Rini wrote: > > Part of the question is then, were you enabling the SSL-related parts > > before this change? Or did the way the code is now being > > enabled/disabled trigger this now being enabled when

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Artem Panfilov
On 29.07.2021 01:56, Tom Rini wrote: > Part of the question is then, were you enabling the SSL-related parts > before this change? Or did the way the code is now being > enabled/disabled trigger this now being enabled when it wasn't before? > This commit broke the build: https://gitlab.com/u-boo

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Artem Panfilov
On 28.07.2021 23:07, Tom Rini wrote: > There is a fine line at least that I'm willing to walk in terms of > supporting ancient OSes directly and also not making things overly > complicated in our own tree. That said, openssl tends to be one of the > ones where it does get hard to support old ver

[PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Artem Panfilov
Fix LibreSSL compilation for versions before v2.7.0. Fix following compilation issue when CONFIG_TOOLS_LIBCRYPTO is enabled: tools/lib/ecdsa/ecdsa-libcrypto.o: In function `prepare_ctx': ecdsa-libcrypto.c:(.text+0x94): undefined reference to `OPENSSL_init_ssl' ecdsa-libcrypto.c:(.text+0x148): unde

[PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Artem Panfilov
Fix LibreSSL compilation for versions before v2.7.0. Fix following compilation issue when CONFIG_TOOLS_LIBCRYPTO is enabled: tools/lib/ecdsa/ecdsa-libcrypto.o: In function `prepare_ctx': ecdsa-libcrypto.c:(.text+0x94): undefined reference to `OPENSSL_init_ssl' ecdsa-libcrypto.c:(.text+0x148): unde

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Tom Rini
On Thu, Jul 29, 2021 at 01:29:35AM +0300, Artem Panfilov wrote: > > On 28.07.2021 23:07, Tom Rini wrote: > > There is a fine line at least that I'm willing to walk in terms of > > supporting ancient OSes directly and also not making things overly > > complicated in our own tree. That said, openss

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Tom Rini
On Wed, Jul 28, 2021 at 03:00:44PM -0500, Alex G. wrote: > Hi Artem, > > I'm re-adding the u-boot mailing list to the CC field, as I see your email > contains no sensitive information. > > On 7/28/21 2:30 PM, Artem Panfilov wrote: > > We have broken CI builds on your bare-metal CentOS 7 servers w

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Alex G.
Hi Artem, I'm re-adding the u-boot mailing list to the CC field, as I see your email contains no sensitive information. On 7/28/21 2:30 PM, Artem Panfilov wrote: We have broken CI builds on your bare-metal CentOS 7 servers with latest master. I think it is good reason to have  a support. Our

Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0

2021-07-28 Thread Alex G.
On 7/28/21 1:10 PM, Artem Panfilov wrote: Fix LibreSSL compilation for versions before v2.7.0. Fix following compilation issue when CONFIG_TOOLS_LIBCRYPTO is enabled: tools/lib/ecdsa/ecdsa-libcrypto.o: In function `prepare_ctx': ecdsa-libcrypto.c:(.text+0x94): undefined reference to `OPENSSL_