Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
Hi Michael, On Mon, 15 Apr 2024 at 22:55, Michael Nazzareno Trimarchi wrote: > > Very good job ;) to fix it. Just add Suggest-by: ;) Thank you for your advice. I sent following v2 patch. https://lore.kernel.org/u-boot/20240416002624.1909-1-yasuharu.shib...@gmail.com/ -- Best regards, Yasuharu

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Fabio Estevam
Hi Yasuharu, On Mon, Apr 15, 2024 at 10:01 AM Yasuharu Shibata wrote: > > If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num > isn't satisfied and store_block() isn't called. > The condition has a wrap around issue, so it is fixed in this patch. > > Signed-off-by: Yasuharu Shibata

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
Hi On Mon, Apr 15, 2024 at 3:55 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Mon, Apr 15, 2024 at 3:48 PM Yasuharu Shibata > wrote: > > > > Hi Michael, > > > > On Mon, 15 Apr 2024 at 22:03, Michael Nazzareno Trimarchi > > wrote: > > > > > > I think I have sent some time ago ;) > > > > >

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
Hi On Mon, Apr 15, 2024 at 3:48 PM Yasuharu Shibata wrote: > > Hi Michael, > > On Mon, 15 Apr 2024 at 22:03, Michael Nazzareno Trimarchi > wrote: > > > > I think I have sent some time ago ;) > > > > Anyway look sane. I was having the same feeling on code inspection > > > > Reviewed-by: Michael T

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
Hi Michael, On Mon, 15 Apr 2024 at 22:03, Michael Nazzareno Trimarchi wrote: > > I think I have sent some time ago ;) > > Anyway look sane. I was having the same feeling on code inspection > > Reviewed-by: Michael Trimarchi Thank you for your review. I already checked the thread, sorry I couldn

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
Hi On Mon, Apr 15, 2024 at 3:01 PM Yasuharu Shibata wrote: > > If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num > isn't satisfied and store_block() isn't called. > The condition has a wrap around issue, so it is fixed in this patch. > > Signed-off-by: Yasuharu Shibata > --- >

[PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Yasuharu Shibata
If tcp_seq_num is wrap around, tcp_seq_num >= initial_data_seq_num isn't satisfied and store_block() isn't called. The condition has a wrap around issue, so it is fixed in this patch. Signed-off-by: Yasuharu Shibata --- net/wget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --