Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Heinrich Schuchardt
Am 20. Mai 2021 21:33:42 MESZ schrieb Alper Nebi Yasak : >On 17/05/2021 16:21, Heinrich Schuchardt wrote: >> If you are asked for a sudo password, you have not install >libguestfs. >> >> Please, install the missing package. > >This also might have ended up not in PATH like mkfs.* weren't in mine,

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Alper Nebi Yasak
On 17/05/2021 16:21, Heinrich Schuchardt wrote: > If you are asked for a sudo password, you have not install libguestfs. > > Please, install the missing package. This also might have ended up not in PATH like mkfs.* weren't in mine, does e.g. "guestmount --version" work from your shell?

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Alper Nebi Yasak
On 17/05/2021 17:06, Andy Shevchenko wrote: > I would like to be helpful here and when I have time, I'll look at it > closer if nobody beats me up to it. Currently I checked the reason why > we skip them in my scenario: > short test summary info > ==

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 8:57 PM Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 8:08 PM Heinrich Schuchardt > wrote: > > On 17.05.21 16:06, Andy Shevchenko wrote: > > ... > > > Let's look at the code without your patch: > > > > We have multiple functions ending with: > > > > umount_fs(mou

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 8:08 PM Heinrich Schuchardt wrote: > On 17.05.21 16:06, Andy Shevchenko wrote: ... > Let's look at the code without your patch: > > We have multiple functions ending with: > > umount_fs(mount_dir) > except CalledProcessError as err: > pytest.skip('Setup failed for

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Heinrich Schuchardt
On 17.05.21 16:06, Andy Shevchenko wrote: > On Mon, May 17, 2021 at 4:29 PM Tom Rini wrote: >> On Mon, May 17, 2021 at 03:21:41PM +0200, Heinrich Schuchardt wrote: >>> On 17.05.21 13:44, Andy Shevchenko wrote: On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt wrote: > > On 17

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Tom Rini
On Mon, May 17, 2021 at 04:24:46PM +0200, Heinrich Schuchardt wrote: > On 17.05.21 15:21, Heinrich Schuchardt wrote: > > On 17.05.21 13:44, Andy Shevchenko wrote: > >> On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > >> wrote: > >>> > >>> On 17.05.21 13:16, Andy Shevchenko wrote: > On M

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Heinrich Schuchardt
On 17.05.21 15:21, Heinrich Schuchardt wrote: > On 17.05.21 13:44, Andy Shevchenko wrote: >> On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt >> wrote: >>> >>> On 17.05.21 13:16, Andy Shevchenko wrote: On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > On 17.05.21

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 4:29 PM Tom Rini wrote: > On Mon, May 17, 2021 at 03:21:41PM +0200, Heinrich Schuchardt wrote: > > On 17.05.21 13:44, Andy Shevchenko wrote: > > > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > > > wrote: > > >> > > >> On 17.05.21 13:16, Andy Shevchenko wrote: > >

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Tom Rini
On Mon, May 17, 2021 at 03:21:41PM +0200, Heinrich Schuchardt wrote: > On 17.05.21 13:44, Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > > wrote: > >> > >> On 17.05.21 13:16, Andy Shevchenko wrote: > >>> On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchar

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 4:21 PM Heinrich Schuchardt wrote: > On 17.05.21 13:44, Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > > wrote: > >> On 17.05.21 13:16, Andy Shevchenko wrote: > >>> On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > >>

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Heinrich Schuchardt
On 17.05.21 13:44, Andy Shevchenko wrote: > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > wrote: >> >> On 17.05.21 13:16, Andy Shevchenko wrote: >>> On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: On 17.05.21 08:33, Andy Shevchenko wrote: > On Thu, May 13, 20

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt wrote: > > On 17.05.21 13:16, Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > >> On 17.05.21 08:33, Andy Shevchenko wrote: > >>> On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt > >>> wrote:

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Heinrich Schuchardt
On 17.05.21 13:16, Andy Shevchenko wrote: > On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: >> On 17.05.21 08:33, Andy Shevchenko wrote: >>> On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt >>> wrote: Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) moun

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > On 17.05.21 08:33, Andy Shevchenko wrote: > > On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt > > wrote: > >> > >> Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system") > >> the following tests are ski

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Heinrich Schuchardt
On 17.05.21 08:33, Andy Shevchenko wrote: > On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt > wrote: >> >> Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system") >> the following tests are skipped: >> >> test/py/tests/test_fs/test_basic.py >> test/py/tests/test_fs/test_ext

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-16 Thread Andy Shevchenko
On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt wrote: > > Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system") > the following tests are skipped: > > test/py/tests/test_fs/test_basic.py > test/py/tests/test_fs/test_ext.py > > SKIPPED [13] test/py/tests/test_fs/conftest.p

[PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-13 Thread Heinrich Schuchardt
Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mounted system") the following tests are skipped: test/py/tests/test_fs/test_basic.py test/py/tests/test_fs/test_ext.py SKIPPED [13] test/py/tests/test_fs/conftest.py:350: Setup failed for filesystem: ext4. Command 'guestmount -a build-san