Re: [PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-20 Thread Bin Meng
On Sun, Feb 16, 2020 at 4:22 AM Heinrich Schuchardt wrote: > > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/clk/intel/clk_intel.c | 4 > 1 file

Re: [PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-16 Thread Simon Glass
On Sat, 15 Feb 2020 at 13:22, Heinrich Schuchardt wrote: > > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/clk/intel/clk_intel.c | 4 > 1 file

Re: [PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-16 Thread Lukasz Majewski
On Sat, 15 Feb 2020 21:22:00 +0100 Heinrich Schuchardt wrote: > If all branches of a switch statement have a return instruction, all > subsequent lines are unreachable. > > Identified with cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/clk/intel/clk_intel.c | 4 > 1

[PATCH 1/1] x86: remove dead code in intel_clk_get_rate()

2020-02-15 Thread Heinrich Schuchardt
If all branches of a switch statement have a return instruction, all subsequent lines are unreachable. Identified with cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/clk/intel/clk_intel.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/clk/intel/clk_intel.c