Re: [PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-28 Thread Tim Harvey
On Sat, Sep 18, 2021 at 4:50 AM Vladimir Oltean wrote: > > While adding the logic for DSA to register a fixed-link PHY for the CPU > port, I forgot to pass it to the .port_disable method too, just > .port_enable. > > Bug had no impact for felix_switch.c, due to the phy argument not being > used, b

Re: [PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 2:50 PM Vladimir Oltean wrote: > > While adding the logic for DSA to register a fixed-link PHY for the CPU > port, I forgot to pass it to the .port_disable method too, just > .port_enable. > > Bug had no impact for felix_switch.c, due to the phy argument not being > used, b

[PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-18 Thread Vladimir Oltean
While adding the logic for DSA to register a fixed-link PHY for the CPU port, I forgot to pass it to the .port_disable method too, just .port_enable. Bug had no impact for felix_switch.c, due to the phy argument not being used, but ksz9477.c does use it => NULL pointer dereference. Fixes: fc054d5