Re: [PATCH 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

2023-04-13 Thread Nishanth Menon
On 23:22-20230413, Marek Behún wrote: > On Thu, Apr 13, 2023 at 02:02:34PM -0500, Nishanth Menon wrote: > > On 20:56-20230413, Marek Behún wrote: > > > On Thu, Apr 13, 2023 at 01:07:12PM -0500, Nishanth Menon wrote: > > > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > >

Re: [PATCH 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

2023-04-13 Thread Marek Behún
On Thu, Apr 13, 2023 at 02:02:34PM -0500, Nishanth Menon wrote: > On 20:56-20230413, Marek Behún wrote: > > On Thu, Apr 13, 2023 at 01:07:12PM -0500, Nishanth Menon wrote: > > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > > > with Linux") reordered the enum

Re: [PATCH 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

2023-04-13 Thread Nishanth Menon
On 20:56-20230413, Marek Behún wrote: > On Thu, Apr 13, 2023 at 01:07:12PM -0500, Nishanth Menon wrote: > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > > with Linux") reordered the enum definitions. This caused the range of > > enums that this api was checking to go

Re: [PATCH 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

2023-04-13 Thread Marek Behún
On Thu, Apr 13, 2023 at 01:07:12PM -0500, Nishanth Menon wrote: > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This caused the range of > enums that this api was checking to go bad. > > While it is possible for the phy

[PATCH 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

2023-04-13 Thread Nishanth Menon
Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux") reordered the enum definitions. This caused the range of enums that this api was checking to go bad. While it is possible for the phy drivers to practically use the enum's directly, drivers such as dp83867 use