Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-08 Thread Tom Rini
On Fri, Mar 08, 2024 at 01:21:15PM +, Conor Dooley wrote: > On Fri, Mar 01, 2024 at 01:54:13PM -0500, Tom Rini wrote: > > On Fri, Mar 01, 2024 at 01:32:53PM +, Conor Dooley wrote: > > > > > > > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini > > > > > > > > > > wrote: > > > > > > > > > > >

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-08 Thread Conor Dooley
On Fri, Mar 01, 2024 at 01:54:13PM -0500, Tom Rini wrote: > On Fri, Mar 01, 2024 at 01:32:53PM +, Conor Dooley wrote: > > > > > > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini > > > > > > > > > wrote: > > > > > > > > > > I think the commit in question can be > > > > > > > > > > summarized as

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
On Tue, Feb 27, 2024 at 12:40 PM Sébastien Szymanski wrote: > > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with > linux") removed the display timings from the board device tree whereas > they are still needed by the mxsfb driver. > Add the timings back (the correct ones) in

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
On Mon, Mar 4, 2024 at 10:35 AM Tom Rini wrote: > For v2024.04 yes, this is fine. For long term, we should parse the new > timing properties that the simple panel driver takes in our simple panel > driver instead. Sounds good. Sébastien, please follow Tom's suggestion when you have a chance.

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Tom Rini
On Mon, Mar 04, 2024 at 10:04:28AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Tue, Feb 27, 2024 at 12:42 PM Tom Rini wrote: > > > What's the long term fix here? Why aren't these needed in Linux anymore, > > and perhaps why was it OK to remove them? This is perhaps another case > > where we as

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-04 Thread Fabio Estevam
Hi Tom, On Tue, Feb 27, 2024 at 12:42 PM Tom Rini wrote: > What's the long term fix here? Why aren't these needed in Linux anymore, > and perhaps why was it OK to remove them? This is perhaps another case > where we as the U-Boot community need to go and talk with some Linux > Kernel community

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-01 Thread Tom Rini
On Fri, Mar 01, 2024 at 01:32:53PM +, Conor Dooley wrote: > Hey, > > Replying here because this is only version of this in my inbox atm. Please note that for additional context, in 2019 when d9aa4d4fca67 ("ARM: dts: opos6uldev: use OF graph to describe the display") was merged re-sync of DTS

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-01 Thread Tom Rini
On Fri, Mar 01, 2024 at 10:17:35AM +0100, Sébastien Szymanski wrote: > On 3/1/24 07:02, Sumit Garg wrote: > > On Thu, 29 Feb 2024 at 19:31, Tom Rini wrote: > > > > > > On Thu, Feb 29, 2024 at 08:42:42AM -0500, Tom Rini wrote: > > > > On Thu, Feb 29, 2024 at 11:17:28AM +0530, Sumit Garg wrote: >

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-01 Thread Conor Dooley
Hey, Replying here because this is only version of this in my inbox atm. On Fri, Mar 01, 2024 at 10:17:35AM +0100, Sébastien Szymanski wrote: > On 3/1/24 07:02, Sumit Garg wrote: > > On Thu, 29 Feb 2024 at 19:31, Tom Rini wrote: > > > On Thu, Feb 29, 2024 at 08:42:42AM -0500, Tom Rini wrote: >

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-03-01 Thread Sébastien Szymanski
On 3/1/24 07:02, Sumit Garg wrote: On Thu, 29 Feb 2024 at 19:31, Tom Rini wrote: On Thu, Feb 29, 2024 at 08:42:42AM -0500, Tom Rini wrote: On Thu, Feb 29, 2024 at 11:17:28AM +0530, Sumit Garg wrote: On Wed, 28 Feb 2024 at 20:50, Tom Rini wrote: On Wed, Feb 28, 2024 at 07:44:42PM +0530,

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-29 Thread Sumit Garg
On Thu, 29 Feb 2024 at 19:31, Tom Rini wrote: > > On Thu, Feb 29, 2024 at 08:42:42AM -0500, Tom Rini wrote: > > On Thu, Feb 29, 2024 at 11:17:28AM +0530, Sumit Garg wrote: > > > On Wed, 28 Feb 2024 at 20:50, Tom Rini wrote: > > > > > > > > On Wed, Feb 28, 2024 at 07:44:42PM +0530, Sumit Garg

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-29 Thread Tom Rini
On Thu, Feb 29, 2024 at 08:42:42AM -0500, Tom Rini wrote: > On Thu, Feb 29, 2024 at 11:17:28AM +0530, Sumit Garg wrote: > > On Wed, 28 Feb 2024 at 20:50, Tom Rini wrote: > > > > > > On Wed, Feb 28, 2024 at 07:44:42PM +0530, Sumit Garg wrote: > > > > + Shawn, Krzysztof, Conor > > > > > > > > Hi

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-29 Thread Tom Rini
On Thu, Feb 29, 2024 at 11:17:28AM +0530, Sumit Garg wrote: > On Wed, 28 Feb 2024 at 20:50, Tom Rini wrote: > > > > On Wed, Feb 28, 2024 at 07:44:42PM +0530, Sumit Garg wrote: > > > + Shawn, Krzysztof, Conor > > > > > > Hi Tom, > > > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini wrote: > > > > >

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-28 Thread Sumit Garg
On Wed, 28 Feb 2024 at 20:50, Tom Rini wrote: > > On Wed, Feb 28, 2024 at 07:44:42PM +0530, Sumit Garg wrote: > > + Shawn, Krzysztof, Conor > > > > Hi Tom, > > > > On Wed, 28 Feb 2024 at 18:40, Tom Rini wrote: > > > > > > On Wed, Feb 28, 2024 at 10:09:13AM +0300, Dan Carpenter wrote: > > > > On

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-28 Thread Tom Rini
On Wed, Feb 28, 2024 at 07:44:42PM +0530, Sumit Garg wrote: > + Shawn, Krzysztof, Conor > > Hi Tom, > > On Wed, 28 Feb 2024 at 18:40, Tom Rini wrote: > > > > On Wed, Feb 28, 2024 at 10:09:13AM +0300, Dan Carpenter wrote: > > > On Tue, Feb 27, 2024 at 04:40:01PM +0100, Sébastien Szymanski wrote:

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-28 Thread Sumit Garg
+ Shawn, Krzysztof, Conor Hi Tom, On Wed, 28 Feb 2024 at 18:40, Tom Rini wrote: > > On Wed, Feb 28, 2024 at 10:09:13AM +0300, Dan Carpenter wrote: > > On Tue, Feb 27, 2024 at 04:40:01PM +0100, Sébastien Szymanski wrote: > > > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with >

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-28 Thread Tom Rini
On Wed, Feb 28, 2024 at 10:09:13AM +0300, Dan Carpenter wrote: > On Tue, Feb 27, 2024 at 04:40:01PM +0100, Sébastien Szymanski wrote: > > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with > > linux") removed the display timings from the board device tree whereas > > they are

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-27 Thread Dan Carpenter
On Tue, Feb 27, 2024 at 04:40:01PM +0100, Sébastien Szymanski wrote: > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with > linux") removed the display timings from the board device tree whereas > they are still needed by the mxsfb driver. > Add the timings back (the correct ones)

Re: [PATCH 1/2] opos6uldev: make the LCD work again

2024-02-27 Thread Tom Rini
On Tue, Feb 27, 2024 at 04:40:01PM +0100, Sébastien Szymanski wrote: > Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with > linux") removed the display timings from the board device tree whereas > they are still needed by the mxsfb driver. > Add the timings back (the correct

[PATCH 1/2] opos6uldev: make the LCD work again

2024-02-27 Thread Sébastien Szymanski
Commit 5d7a95f4 ("imx6ul/imx6ull: synchronise device trees with linux") removed the display timings from the board device tree whereas they are still needed by the mxsfb driver. Add the timings back (the correct ones) in the imx6ul-opos6uldev-u-boot.dtsi file and remove them from the