Re: [PATCH 1/3] clk: rockchip: rk3308: Fix ordering between masking and shifting

2023-08-03 Thread Kever Yang
On 2023/8/3 19:08, Massimo Pegorer wrote: As per definitions of masks and shift offsets in cru_rk3308.h, values read from registers must be first masked and then shifted. By the way, this fix is binary invariant, because in all of fixed cases the shift offset is zero. Signed-off-by: Massimo Pe

[PATCH 1/3] clk: rockchip: rk3308: Fix ordering between masking and shifting

2023-08-03 Thread Massimo Pegorer
As per definitions of masks and shift offsets in cru_rk3308.h, values read from registers must be first masked and then shifted. By the way, this fix is binary invariant, because in all of fixed cases the shift offset is zero. Signed-off-by: Massimo Pegorer --- drivers/clk/rockchip/clk_rk3308.c