Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hello, On 2024-06-28 08:51, Etienne Dublé wrote: Le 27/06/2024 à 14:27, Quentin Schulz a écrit : On 6/25/24 1:42 PM, Etienne Dublé wrote: Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and s

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hi Quentin, Le 27/06/2024 à 14:27, Quentin Schulz a écrit : Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). Wha

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). What do you think? I guess that's one way, I'm also wondering how

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). What do you think? I guess that's one way, I'm also wondering how systemd renames those to be unique but stable on the

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hello, On 2024-06-25 12:03, Quentin Schulz wrote: On 6/25/24 8:38 AM, Etienne Dublé wrote: Thanks for reviewing my patches. Le 24/06/2024 à 15:08, Quentin Schulz a écrit : [...]   1 file changed, 11 insertions(+) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 93e83661ce..

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hi Etienne, On 6/25/24 8:38 AM, Etienne Dublé wrote: Hi Quentin, Thanks for reviewing my patches. Le 24/06/2024 à 15:08, Quentin Schulz a écrit : [...]   1 file changed, 11 insertions(+) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 93e83661ce..b30d51731f 100644 --- a/dr

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hi Quentin, Thanks for reviewing my patches. Le 24/06/2024 à 15:08, Quentin Schulz a écrit : [...]   1 file changed, 11 insertions(+) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 93e83661ce..b30d51731f 100644 --- a/drivers/net/rtl8169.c +++ b/drivers/net/rtl8169.c @@ -109

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

Hi Etienne, On 6/24/24 2:40 PM, ETIENNE DUBLE wrote: This commit implements the .bind member function, and gives a different name to interfaces: "RTL8169#0", "RTL8169#1", etc. This was tested on a FriendlyElec Nanopi R5C board, which has two RTL-8125B interfaces managed by this driver. Since th

[PATCH 1/3] net: give a different name to rtl8169 interfaces

This commit implements the .bind member function, and gives a different name to interfaces: "RTL8169#0", "RTL8169#1", etc. This was tested on a FriendlyElec Nanopi R5C board, which has two RTL-8125B interfaces managed by this driver. Since they were given the same name, it was previously not possi