Re: [PATCH 1/3] serial: uniphier: use register macros instead of structure

2020-07-11 Thread Masahiro Yamada
On Fri, Jul 10, 2020 at 1:13 AM Masahiro Yamada wrote: > > After all, I am not a big fan of using a structure to represent the > hardware register map. > > You do not need to know the entire register map. > > Add only necessary register macros. > > Use FIELD_PREP() instead of maintaining a pair of

[PATCH 1/3] serial: uniphier: use register macros instead of structure

2020-07-09 Thread Masahiro Yamada
After all, I am not a big fan of using a structure to represent the hardware register map. You do not need to know the entire register map. Add only necessary register macros. Use FIELD_PREP() instead of maintaining a pair of shift and mask. Signed-off-by: Masahiro Yamada --- drivers/serial/