Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-15 Thread Tom Rini
On Fri, Jul 10, 2020 at 11:13:50AM +0200, Thomas Petazzoni wrote: > On Fri, 10 Jul 2020 10:54:24 +0200 > Rasmus Villemoes wrote: > > > > It's very much like the FAT filesystem case: if you have U-Boot proper > > > and your Linux kernel image in a FAT filesystem, > > > > No, this is very much

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-15 Thread Tom Rini
On Thu, Jul 09, 2020 at 07:51:45PM +0200, Joao Marcos Costa wrote: > Add support for SquashFS filesystem. Right now, it does not support > compression but support for zlib will be added in a follow-up commit. > > Signed-off-by: Joao Marcos Costa Sorry for the delay. If you run this patch throu

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-10 Thread Thomas Petazzoni
On Fri, 10 Jul 2020 10:54:24 +0200 Rasmus Villemoes wrote: > > It's very much like the FAT filesystem case: if you have U-Boot proper > > and your Linux kernel image in a FAT filesystem, > > No, this is very much _not_ like the above. In this paragraph, you > combine "U-Boot proper and your L

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-10 Thread Rasmus Villemoes
On 10/07/2020 10.29, Thomas Petazzoni wrote: > Hello Rasmus, > > On Thu, 9 Jul 2020 21:50:03 +0200 > Rasmus Villemoes wrote: > >>> +config SPL_FS_SQUASHFS >>> + bool "Support SquashFS filesystems" >>> + select FS_SQUASHFS >> >> Is there any reason U-Boot proper must support squashfs if the

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-10 Thread Thomas Petazzoni
Hello Rasmus, On Thu, 9 Jul 2020 21:50:03 +0200 Rasmus Villemoes wrote: > > +config SPL_FS_SQUASHFS > > + bool "Support SquashFS filesystems" > > + select FS_SQUASHFS > > Is there any reason U-Boot proper must support squashfs if the SPL does? > This isn't quite specific to this patch; I

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-09 Thread Joao Marcos Costa
Hello! On Thu, 9 Jul 2020 21:50:03 +0200 Rasmus Villemoes wrote: > On 09/07/2020 19.51, Joao Marcos Costa wrote: > > Add support for SquashFS filesystem. Right now, it does not support > > compression but support for zlib will be added in a follow-up > > commit. > > Cool, thanks for proposing

Re: [PATCH 1/4] fs/squashfs: new filesystem

2020-07-09 Thread Rasmus Villemoes
On 09/07/2020 19.51, Joao Marcos Costa wrote: > Add support for SquashFS filesystem. Right now, it does not support > compression but support for zlib will be added in a follow-up commit. Cool, thanks for proposing this. While I'm not really in a position to review these, just one comment below.

[PATCH 1/4] fs/squashfs: new filesystem

2020-07-09 Thread Joao Marcos Costa
Add support for SquashFS filesystem. Right now, it does not support compression but support for zlib will be added in a follow-up commit. Signed-off-by: Joao Marcos Costa --- common/spl/Kconfig |9 + fs/Kconfig |2 + fs/Makefile |