Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-11-06 Thread Rasmus Villemoes
On 04/11/2023 20.43, Simon Glass wrote: > Hi Rasmus, > Are you planning a new version of this series? No. AFAICT there's nothing to be done on my end. Rasmus

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-11-04 Thread Simon Glass
Hi Rasmus, On Fri, 29 Sept 2023 at 07:16, Sean Anderson wrote: > > On 9/28/23 03:10, Rasmus Villemoes wrote: > > On 27/09/2023 21.02, Sean Anderson wrote: > >> On 9/19/23 07:37, Rasmus Villemoes wrote: > >>> In some cases, using the "external data" feature is impossible or > >>> undesirable, but

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-29 Thread Sean Anderson
On 9/28/23 03:10, Rasmus Villemoes wrote: On 27/09/2023 21.02, Sean Anderson wrote: On 9/19/23 07:37, Rasmus Villemoes wrote: In some cases, using the "external data" feature is impossible or undesirable, but one may still want (or need) the FIT image to have a certain alignment. Also, given

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-28 Thread Rasmus Villemoes
On 27/09/2023 21.02, Sean Anderson wrote: > On 9/19/23 07:37, Rasmus Villemoes wrote: >> In some cases, using the "external data" feature is impossible or >> undesirable, but one may still want (or need) the FIT image to have a >> certain alignment. Also, given the current 'mkimage -h' output, >>

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-27 Thread Sean Anderson
On 9/19/23 07:37, Rasmus Villemoes wrote: In some cases, using the "external data" feature is impossible or undesirable, but one may still want (or need) the FIT image to have a certain alignment. Also, given the current 'mkimage -h' output, -B => align size in hex for FIT structure and

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-25 Thread Rasmus Villemoes
On 25/09/2023 15.10, Simon Glass wrote: > Hi Rasmus, > > On Mon, 25 Sept 2023 at 02:47, Rasmus Villemoes > wrote: >> Since patches 2,3,4 touch binman code, could you take all four? > > Yes, will do. I didn't pick them up in the most recent PR as I try to > have things sit for a week before

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-25 Thread Simon Glass
Hi Rasmus, On Mon, 25 Sept 2023 at 02:47, Rasmus Villemoes wrote: > > On 22/09/2023 17.26, Simon Glass wrote: > > >>> Shouldn't this be fdt_open_into()? > >> > >> I honestly just copy-pasted fit_extract_data() and shaved it down to the > >> part that does the "align the FDT part of the file". >

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-25 Thread Rasmus Villemoes
On 22/09/2023 17.26, Simon Glass wrote: >>> Shouldn't this be fdt_open_into()? >> >> I honestly just copy-pasted fit_extract_data() and shaved it down to the >> part that does the "align the FDT part of the file". >> >> I don't really understand your question. Are you saying this doesn't >> work

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-22 Thread Simon Glass
Hi Rasmus, On Thu, 21 Sept 2023 at 01:57, Rasmus Villemoes wrote: > > On 21/09/2023 03.02, Simon Glass wrote: > > Hi Rasmus, > > > > On Tue, 19 Sept 2023 at 05:37, Rasmus Villemoes > > wrote: > >> > >> In some cases, using the "external data" feature is impossible or > >> undesirable, but one

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-21 Thread Rasmus Villemoes
On 21/09/2023 03.02, Simon Glass wrote: > Hi Rasmus, > > On Tue, 19 Sept 2023 at 05:37, Rasmus Villemoes > wrote: >> >> In some cases, using the "external data" feature is impossible or >> undesirable, but one may still want (or need) the FIT image to have a >> certain alignment. Also, given the

Re: [PATCH 1/4] mkimage: also honour -B even without external data

2023-09-20 Thread Simon Glass
Hi Rasmus, On Tue, 19 Sept 2023 at 05:37, Rasmus Villemoes wrote: > > In some cases, using the "external data" feature is impossible or > undesirable, but one may still want (or need) the FIT image to have a > certain alignment. Also, given the current 'mkimage -h' output, > > -B => align size

[PATCH 1/4] mkimage: also honour -B even without external data

2023-09-19 Thread Rasmus Villemoes
In some cases, using the "external data" feature is impossible or undesirable, but one may still want (or need) the FIT image to have a certain alignment. Also, given the current 'mkimage -h' output, -B => align size in hex for FIT structure and header it is quite unexpected for -B to be