Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-21 Thread Simon Glass
Hi Sean, On Sat, 20 Jul 2024 at 17:11, Sean Anderson wrote: > > On 7/20/24 02:17, Simon Glass wrote: > > Rather than having every caller set this up individually, create a > > common init function. This allows new fields to be added without the > > risk of them being left uninited. > > > > What i

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. What is the code size impact of this? IIRC the reason why I didn't do this is to avoid

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Michael Nazzareno Trimarchi
Hi On Sat, Jul 20, 2024 at 8:20 AM Simon Glass wrote: > > Rather than having every caller set this up individually, create a > common init function. This allows new fields to be added without the > risk of them being left uninited. > > Signed-off-by: Simon Glass > --- > > arch/arm/mach-imx/spl_

[PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-19 Thread Simon Glass
Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. Signed-off-by: Simon Glass --- arch/arm/mach-imx/spl_imx_romapi.c | 14 ++--- arch/arm/mach-sunxi/spl_spi_sunxi.c | 3 +