Re: [PATCH 14/14] smbios: Correct error handling when writing tables

2024-06-25 Thread Simon Glass
Hi Heinrich, On Sun, 23 Jun 2024 at 22:41, Heinrich Schuchardt wrote: > > > > Am 23. Juni 2024 22:30:33 MESZ schrieb Simon Glass : > >Since write_smbios_table() returns an address, we cannot use it to > >return and error number. Also, failing on sysinfo_detect() breaks > > IS_ERR_VALUE() could

Re: [PATCH 14/14] smbios: Correct error handling when writing tables

2024-06-23 Thread Heinrich Schuchardt
Am 23. Juni 2024 22:30:33 MESZ schrieb Simon Glass : >Since write_smbios_table() returns an address, we cannot use it to >return and error number. Also, failing on sysinfo_detect() breaks IS_ERR_VALUE() could serve as template for conveying errors in addresses. >existing boards, e.g.

[PATCH 14/14] smbios: Correct error handling when writing tables

2024-06-23 Thread Simon Glass
Since write_smbios_table() returns an address, we cannot use it to return and error number. Also, failing on sysinfo_detect() breaks existing boards, e.g. chromebook_link Correct this by logging and swallowing the error. Signed-off-by: Simon Glass Fixes: a5a57562856 ("lib: smbios: Detect system