Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-14 Thread Tom Rini
On Fri, May 05, 2023 at 08:03:04PM -0600, Simon Glass wrote: > This causes crashes on some boards, e.g. rockpro64. In any case, we > should not do it. > > Check the usb_started flag to avoid this. > > Signed-off-by: Simon Glass > Tested-by: Jonas Karlman > Tested-by: Tom Rini Applied to u-bo

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
On 2023-05-06 18:24, Jonas Karlman wrote: > On 2023-05-06 18:00, Tom Rini wrote: >> On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: >>> Hi Simon, >>> >>> On 2023-05-06 04:03, Simon Glass wrote: This causes crashes on some boards, e.g. rockpro64. In any case, we should not d

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
On 2023-05-06 18:00, Tom Rini wrote: > On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: >> Hi Simon, >> >> On 2023-05-06 04:03, Simon Glass wrote: >>> This causes crashes on some boards, e.g. rockpro64. In any case, we >>> should not do it. >>> >>> Check the usb_started flag to avoid

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Tom Rini
On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: > Hi Simon, > > On 2023-05-06 04:03, Simon Glass wrote: > > This causes crashes on some boards, e.g. rockpro64. In any case, we > > should not do it. > > > > Check the usb_started flag to avoid this. > > > > Signed-off-by: Simon Glas

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Tom Rini
On Fri, May 05, 2023 at 08:03:04PM -0600, Simon Glass wrote: > This causes crashes on some boards, e.g. rockpro64. In any case, we > should not do it. > > Check the usb_started flag to avoid this. > > Signed-off-by: Simon Glass Tested-by: Tom Rini -- Tom signature.asc Description: PGP sig

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
Hi Simon, On 2023-05-06 04:03, Simon Glass wrote: > This causes crashes on some boards, e.g. rockpro64. In any case, we > should not do it. > > Check the usb_started flag to avoid this. > > Signed-off-by: Simon Glass > --- > > drivers/usb/host/usb_bootdev.c | 3 +++ > test/boot/bootdev.c

[PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-05 Thread Simon Glass
This causes crashes on some boards, e.g. rockpro64. In any case, we should not do it. Check the usb_started flag to avoid this. Signed-off-by: Simon Glass --- drivers/usb/host/usb_bootdev.c | 3 +++ test/boot/bootdev.c| 5 + 2 files changed, 8 insertions(+) diff --git a/driver