Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-10-04 Thread Ramon Fried
On Fri, Sep 23, 2022 at 12:36 PM Michal Simek wrote: > > Hi, > > On 9/23/22 11:17, Samuel Obuch wrote: > > Hi, I tested both versions to be sure, but the results are as can be > > expected: > > > > 1. both __raw_readl/__raw_writel and readl/writel functions work ok on > > riscv - > > only the or

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-09-23 Thread Michal Simek
Hi, On 9/23/22 11:17, Samuel Obuch wrote: Hi, I tested both versions to be sure, but the results are as can be expected: 1. both __raw_readl/__raw_writel and readl/writel functions work ok on riscv - only the original nonvolatile accesses were problematic 2. the additional barrier in readl/wri

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-09-23 Thread Samuel Obuch
Hi, I tested both versions to be sure, but the results are as can be expected: 1. both __raw_readl/__raw_writel and readl/writel functions work ok on riscv - only the original nonvolatile accesses were problematic 2. the additional barrier in readl/writel functions can introduce noticeable slowdow

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-09-20 Thread Michal Simek
On 9/19/22 19:03, Jan Remes wrote: On Mon, Aug 8, 2022 at 10:05 AM Michal Simek wrote: On 8/6/22 19:33, Ramon Fried wrote: On Wed, Jul 13, 2022 at 5:02 PM Samuel Obuch wrote: Use __raw_read* and __raw_write* functions to ensure read/write is passed to the memory-mapped regions, as non

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-09-20 Thread Jan Remes
On Mon, Aug 8, 2022 at 10:05 AM Michal Simek wrote: > > > > On 8/6/22 19:33, Ramon Fried wrote: > > On Wed, Jul 13, 2022 at 5:02 PM Samuel Obuch > > wrote: > >> > >> Use __raw_read* and __raw_write* functions to ensure read/write > >> is passed to the memory-mapped regions, as non-volatile acces

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-08-08 Thread Michal Simek
On 8/6/22 19:33, Ramon Fried wrote: On Wed, Jul 13, 2022 at 5:02 PM Samuel Obuch wrote: Use __raw_read* and __raw_write* functions to ensure read/write is passed to the memory-mapped regions, as non-volatile accesses may get optimised out. Signed-off-by: Samuel Obuch --- drivers/net/xil

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-08-06 Thread Ramon Fried
On Wed, Jul 13, 2022 at 5:02 PM Samuel Obuch wrote: > > Use __raw_read* and __raw_write* functions to ensure read/write > is passed to the memory-mapped regions, as non-volatile accesses > may get optimised out. > > Signed-off-by: Samuel Obuch > --- > drivers/net/xilinx_emaclite.c | 9 -

[PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-07-13 Thread Samuel Obuch
Use __raw_read* and __raw_write* functions to ensure read/write is passed to the memory-mapped regions, as non-volatile accesses may get optimised out. Signed-off-by: Samuel Obuch --- drivers/net/xilinx_emaclite.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drive