Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-27 Thread Tom Rini
On Wed, Jan 18, 2023 at 01:12:23PM +0100, Michael Walle wrote: > Don't define an empty version for pinconfig_post_bind(). Just guard the > call and let the linker garbage collection do the rest. This way, we > also don't have to do any guesswork. > > Signed-off-by: Michael Walle > Reviewed-by: M

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Marek Vasut
On 1/18/23 14:10, Michael Walle wrote: Am 2023-01-18 14:08, schrieb Marek Vasut: On 1/18/23 13:43, Michael Walle wrote: Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *de

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 14:08, schrieb Marek Vasut: On 1/18/23 13:43, Michael Walle wrote: Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev)   }     /* - * If set_st

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Marek Vasut
On 1/18/23 13:43, Michael Walle wrote: Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev)   }     /* - * If set_state callback is set, we assume this pinctrl

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev) } /* - * If set_state callback is set, we assume this pinctrl driver is the - * full implementation.

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Marek Vasut
On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev) } /* -* If set_state callback is set, we assume this pinctrl driver is the -* full implementation. In this case, its child nodes s

[PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Don't define an empty version for pinconfig_post_bind(). Just guard the call and let the linker garbage collection do the rest. This way, we also don't have to do any guesswork. Signed-off-by: Michael Walle --- drivers/pinctrl/pinctrl-uclass.c | 17 + 1 file changed, 5 insertions