Re: [PATCH 2/3] rockchip: Add a board_gen_ethaddr() function

2024-04-02 Thread Detlev Casanova
Hi Jonas, On Thursday, March 14, 2024 2:38:30 P.M. EDT Jonas Karlman wrote: > Hi Detlev, > > On 2024-03-14 15:43, Detlev Casanova wrote: > > Set the MAC address based on the CPU ID only if the ethernet device has > > no ROM or DT address set. > > This patch changes behavior and once again

Re: [PATCH 2/3] rockchip: Add a board_gen_ethaddr() function

2024-03-14 Thread Jonas Karlman
Hi Detlev, On 2024-03-14 15:43, Detlev Casanova wrote: > Set the MAC address based on the CPU ID only if the ethernet device has > no ROM or DT address set. This patch changes behavior and once again require CONFIG_NET to fixup the device tree with local-mac-address for the ethernet0/1 alias

Re: [PATCH 2/3] rockchip: Add a board_gen_ethaddr() function

2024-03-14 Thread Marek Vasut
On 3/14/24 3:43 PM, Detlev Casanova wrote: Set the MAC address based on the CPU ID only if the ethernet device has no ROM or DT address set. Signed-off-by: Detlev Casanova More of a general design question -- how much of this can be done in MAC driver specific .read_rom_hwaddr callback ?

[PATCH 2/3] rockchip: Add a board_gen_ethaddr() function

2024-03-14 Thread Detlev Casanova
Set the MAC address based on the CPU ID only if the ethernet device has no ROM or DT address set. Signed-off-by: Detlev Casanova --- arch/arm/Kconfig | 1 + arch/arm/include/asm/arch-rockchip/misc.h | 1 + arch/arm/mach-rockchip/board.c| 30