Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-21 Thread Simon Glass
On Tue, 21 Nov 2023 at 10:32, Sam Protsenko wrote: > > On Mon, Nov 13, 2023 at 12:01 PM Simon Glass wrote: > > > > > > The 'port_id' seems to be needed for ARCH_EXYNOS4 boards. Because > > > Exynos4 doesn't have proper DM clocks, it uses 'id' property to get > > > corresponding UART clock

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-21 Thread Sam Protsenko
On Mon, Nov 13, 2023 at 12:01 PM Simon Glass wrote: > > > > The 'port_id' seems to be needed for ARCH_EXYNOS4 boards. Because > > Exynos4 doesn't have proper DM clocks, it uses 'id' property to get > > corresponding UART clock frequency from its mach code. > > > > Here is what's happening in the

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-13 Thread Simon Glass
Hi Sam, On Fri, 10 Nov 2023 at 11:29, Sam Protsenko wrote: > > Hi Simon, > > On Tue, Nov 7, 2023 at 10:26 PM Simon Glass wrote: > > > > Hi Sam, > > > > On Tue, 7 Nov 2023 at 12:06, Sam Protsenko > > wrote: > > > > > > Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id" > >

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-10 Thread Sam Protsenko
Hi Simon, On Tue, Nov 7, 2023 at 10:26 PM Simon Glass wrote: > > Hi Sam, > > On Tue, 7 Nov 2023 at 12:06, Sam Protsenko wrote: > > > > Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id" > > property from device tree, as suggested in [1]. dev_* API is already > > used in this

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-07 Thread Simon Glass
Hi Sam, On Tue, 7 Nov 2023 at 12:06, Sam Protsenko wrote: > > Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id" > property from device tree, as suggested in [1]. dev_* API is already > used in this driver, so there is no reason to stick to fdtdec_* API. > This also fixes

[PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-07 Thread Sam Protsenko
Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id" property from device tree, as suggested in [1]. dev_* API is already used in this driver, so there is no reason to stick to fdtdec_* API. This also fixes checkpatch warning: WARNING: Use the livetree API (dev_read_...)